Hey I try to understand I use `instanceKeeper` for reusing S

Question

Hey I try to understand I use `instanceKeeper` for reusing Store and in init I add `lifecycle doOnDestroy citiesStore dispose ` of cause it doesn t work after configuration was changed when should I dispose my store if I reuse instance via instanceKeeper

Arkadii Ivanov · Answer

Hello This case is covered in samples Also you can check samples in the docs In general To retain a `Store` you can use `getOrCreateStore` extension function To retain an arbitrary object you can use `getOrCreate` extension function It provides you a wrapped `Lifecycle` that is destroyed then when the object is completely gone

lehakorshun · Answer

yes I saw it and in your sample you don t dispose ListStore when lifecycle call onDestroy

lehakorshun · Answer

maybe it is overhead but I want to dispose all my store when lifecycle call onCleared method on ViewModel

Arkadii Ivanov · Answer

It should be destroyed when the related `ViewModel` is cleared That s the whole purpose of the extension

Arkadii Ivanov · Answer

Here is the related test <https github com arkivanov MVIKotlin blob 41a47c0fb022bc79312053d7605f83a02e1b5df7 mvikotlin extensions androidx src androidTest kotlin com arkivanov mvikotlin extensions androidx instancekeeper AndroidInstanceKeeperTest kt L27>

Arkadii Ivanov · Answer

So the `Store` supposed to be destroyed when the `Lifecycle` is destroyed and the `Store` is not retained anymore its `ViewModel` is cleared But when the `Store` is retained it should not be disposed

lehakorshun · Answer

ok go step by step slightly smiling face in the sample you call todoAddStore dispose on every doOnDestroy call but why you don t call the dispose method for list store

Arkadii Ivanov · Answer

Because the `TodoListStore` is retained but the `TodoAddStore` is not

lehakorshun · Answer

I think we don t have to dispose AddSotre too

Arkadii Ivanov · Answer

The it will be leaked

Arkadii Ivanov · Answer

In the next instance of the controller there will a new instance of the `TodoAddStore`

lehakorshun · Answer

yes but what will leaked

lehakorshun · Answer

it is similar to the list store

Arkadii Ivanov · Answer

So every `Store` should be destroyed at the end of its own lifecycle `TodoListStore` has a lifecycle equal to a `ViewModel` So it is disposed when the `ViewModel` is cleared normally when the screen is closed But `TodoAddStore` has a lifecycle equal to screen So it should be disposed when the screen is destroyed e g when configuration change

lehakorshun · Answer

I fully agree But I can t find place where gt So it is disposed when the `ViewModel` is cleared is called

Arkadii Ivanov · Answer

When the list screen is rotated then `TodoListStore` instance is retained passed to the new instance of the list screen So it is not disposed at this point But `TodoAddStore` is not retained When the new instance of the screen is created a new instance of `TodoAddStore` is created as well So previous instance of `TodoAddStore` is disposed

Arkadii Ivanov · Answer

The `getOrCreate` extension method provides another `Lifecycle` which is destroyed when the `ViewModel` is cleared Each `InstanceKeeper` has a `Lifecycle`

lehakorshun · Answer

thx I need to check this point slightly smiling face

lehakorshun · Answer

< Arkadii Ivanov> thx for explanations i didn t see dispose in this peace of code ```getOrCreate lifecycle gt val store = factory lifecycle doOnDestroy store dispose store ```

Arkadii Ivanov · Answer

You are welcome