Hey! Are there plans adding more flexible logging ...

# mvikotlin

[aiidziis]

Hey! Are there plans adding more flexible logging strategy for mvikotlin-logging , for now everything gets logged, storeName , eventType and value , but value sometimes gets huge (mainly because of Model and State data classes) and pollutes the logcat. I saw that now we can specify maxLenght for log message, but that is more like guessing game.

[Arkadii Ivanov]

Hey! Currently you can customize the following:
• maxLength
• eventTypes
• use custom Logger
https://github.com/arkivanov/MVIKotlin/blob/master/mvikotlin-logging/src/commonMain/kotlin/com/arkivanov/mvikotlin/logging/store/LoggingStoreFactory.kt#L22

[Arkadii Ivanov]

How would you like to make it more flexible? Now it's a good timing since stable version is not release yet.

[Arkadii Ivanov]

I will review the logging functionality before release.

[aiidziis]

Actually only thing that is bothering me that you can’t opt out of value logging, because storeName and eventType are mandatory, but value sometimes pollutes logcat.

[aiidziis]

https://github.com/arkivanov/MVIKotlin/blob/master/mvikotlin-logging/src/commonMain/kotlin/com/arkivanov/mvikotlin/logging/store/LoggingStoreFactory.kt#L36
I guess this is the line where my custom Logger would get the log message.

[Arkadii Ivanov]

So basically you would like to log everything but values?

[aiidziis]

yes

[Arkadii Ivanov]

Thanks, I will keep this in mind. I think it is doable.

[Arkadii Ivanov]

PR has merged, let me know if you have any questions. https://github.com/arkivanov/MVIKotlin/pull/97

[aiidziis]

Nice! Looks good. 🤩