Curious if Mavericks has any code coverage numbers...
# mvrxk
kenkyee
10/19/2021, 3:11 PMCurious if Mavericks has any code coverage numbers for the library core code?
e
elihart
10/19/2021, 11:55 PMwe do have the jacoco plugin set up but I haven’t looked at the report in a while
k
kenkyee
10/20/2021, 1:14 AMWould be nice if that reported results to the repo as a badge 🙂
e
elihart
10/20/2021, 1:42 AMfor sure, contributions welcome 😄
k
kenkyee
10/20/2021, 11:58 AMHacktober so let me see what I can do 🙂
🙏 1
kenkyee
10/21/2021, 1:40 AMCoverage numbers from running manually in case anyone is curious:
mvrx module: 54%
mvrx-navigation: 39%
mvrx-rxjava2: 48%
mvrx-mocking: 52%
Still trying to figure out why Jacoco doesn't output XML reports even though I enabled it so I can hook it to codecov.io... 🤔
e
elihart
10/21/2021, 6:28 PMoh nice, that’s great progress
k
kenkyee
10/23/2021, 10:16 PMFYI: https://github.com/airbnb/mavericks/pull/585
Had to rewrite the Jacoco stuff...looks cleaner now 🙂
e
elihart
10/26/2021, 7:30 PMamazing, thanks! I’ll review soon
k
kenkyee
10/29/2021, 12:57 AMBTW, you have to set up a codecov account and add the env var w/ the ID to CI to get the codecov badge to work properly...noticed the badge doesn't show a percentage 🙂
Added another PR to bump Kotlin/Compose/Koin and get rid of jcenter():
https://github.com/airbnb/mavericks/pull/586
e
elihart
10/29/2021, 1:49 AMthanks, I’ll try to get to that
4 Views