https://kotlinlang.org logo
Title
j

Jim

01/30/2021, 10:24 PM
That's one scary looking issue up in there 😂
s

sam

01/30/2021, 10:25 PM
lol
j

Jim

01/30/2021, 10:25 PM
I assume 191 depends on 190?
s

sam

01/30/2021, 10:25 PM
Yeah I'm updating core now
j

Jim

01/30/2021, 10:26 PM
I think maybe the way forward is to try to do: hoplite-serializationx as MPP, then once that's done, move all of the hoplite-json code into the former, and somehow make that implementation optional
s

sam

01/30/2021, 10:26 PM
yeah I agree
j

Jim

01/30/2021, 10:27 PM
From what I can tell the json parser does a lot of the work for you in kotlinx-serialization, and I'm not sure I can just get at the guts like you can with jackson
s

sam

01/30/2021, 10:27 PM
the other thing is, as we discussed, in MPP mode you will need to explictly add your parsers
So you can just choose to add JimJsonParser
but on JVM we'll continue to use service loaders?
Alternatively, we can just bump to 2.0, rename hoplite-json to hoplite-jackson
j

Jim

01/30/2021, 10:28 PM
hmmm that's an option too
s

sam

01/30/2021, 10:28 PM
I think going MPP is a big enough change to warrant 2.0
j

Jim

01/30/2021, 10:28 PM
true
ok I'll monitor 190 and once that's done I'll just try to do hoplite-jimwhatever as a proof of concept
s

sam

01/30/2021, 10:29 PM
ok