I can see how the first version is more concise

But also kind of breaks the symmetry...

Maybe we can make it so that if

userViewer

is called and not stored into one field, it throws a runtime error

For the list, how would you like to handle multiple items? Something like this?

preferredTrips {
      edge { node { kind = "MUSIC" } }
      edge { node { kind = "VIDEO" } }
    }

There is already an issue for check result: https://youtrack.jetbrains.com/issue/KT-12719/Add-CheckResult-MustUseReturnValue-to-warn-about-unused-return-v

Issue galore \o/

Hey, tried out the snapshot, and just wanted to let you know, there is some code with compilation errors that gets generated: It’s such a silly reason, I would’ve totally expected this to work but I guess the way the code is parsed it doesn’t. So the problem is from the final return type being put after the

return

keyword, on the next line, showing it off as

Unreachable code

, and the return keyword with “This function must return a value of type Map<String, Any?>” Aka the code is parsed wrong, and this is one of the few cases where I guess it’d work if Kotlin had semicolons right 😂 In one of my test builders, this is generated:

public
    fun additionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetails(block: AdditionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetailsBuilder.() -> Unit
    = {}): Map<String, Any?> {
  __shouldBeAssignedFields.add("submitAdditionalPaymentDetails")
  return
      AdditionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetailsBuilder().apply(block).build()
}

while what should’ve been generated and would work is this

public
    fun additionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetails(block: AdditionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetailsBuilder.() -> Unit
    = {}): Map<String, Any?> {
  __shouldBeAssignedFields.add("submitAdditionalPaymentDetails")
  return AdditionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetailsBuilder().apply(block).build()
}

so that's missing in this case, I can make a quick fix 🙂

Btw this makes me thing, this would make me at least a bit paranoid. Like having to add the special spacing character instead of normal space in every place where such code is generated. Is this what you’re gonna do now, or just for this specific case? I am not sure what’s best practice when using KotlinPoet

here we go