https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hiring-french
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
j

Jan Skrasek

05/10/2022, 9:39 AM
Hi guys, I was trying out testing builders and I have to admit that I got burned a bit. This is what I have to have:
val data = UserDataQuery.Data {
  viewer = userViewer {
    userId = "userId"
    identity = identity {
      email = "<mailto:jon.snow@example.com|jon.snow@example.com>"
      name = name {
        first = "Jon"
        last = "Snow"
      }
    }
    preferredTrips = preferredTrips {
      edges = listOf(edge { node = node { kind = "MUSIC" } })
    }
  }
}
This was my first attempt:
val data = UserDataQuery.Data {
  userViewer {
    userId = "userId"
    identity {
      email = "<mailto:jon.snow@example.com|jon.snow@example.com>"
      name {
        first = "Jon"
        last = "Snow"
      }
    }
    preferredTrips {
      edge { node { kind = "MUSIC" } }
    }
  }
}
Have you considered something like this?
m

mbonnin

05/10/2022, 9:39 AM
Hi 👋
j

Jan Skrasek

05/10/2022, 9:40 AM
(A side note: current solution would utilize CheckResult annotation from Androidx to see this directly linted as not used result, though I understand that in multiplatform this is problematic.)
m

mbonnin

05/10/2022, 9:41 AM
Right
I can see how the first version is more concise
But also kind of breaks the symmetry...
Maybe we can make it so that if
userViewer
is called and not stored into one field, it throws a runtime error
For the list, how would you like to handle multiple items? Something like this?
preferredTrips {
      edge { node { kind = "MUSIC" } }
      edge { node { kind = "VIDEO" } }
    }
s

Stylianos Gakis

05/10/2022, 10:17 AM
I think this is an important detail. I like the way these builders are explicit about which field is getting populated by setting
identity = identity {...}
. I am not sure if the ambiguity would be worth it with the other approach. Just throwing my opinion out there 😅
👍 2
m

mbonnin

05/10/2022, 10:19 AM
The unused return value is definitely a footgun but if we can detect it early enough that should be alright 🤞
b

bod

05/10/2022, 10:42 AM
(Related: I've created this issue asking for a check like the one that exists in Java)
👍 1
j

Jan Skrasek

05/10/2022, 10:44 AM
I guess I expected more something like this: https://kotlinlang.org/docs/type-safe-builders.html Of course, now I know how to use it, there is not much of issues .... 😄 Yet I hoped for less of the code.
b

bod

05/10/2022, 11:05 AM
Woops thanks! I searched before creating the issue, I swear 😅
😅 2
m

mbonnin

05/10/2022, 1:20 PM
And I opened this one to fail on unused return values in test builders https://github.com/apollographql/apollo-kotlin/issues/4093
👍 2
Issue galore \o/
s

Stylianos Gakis

05/19/2022, 9:58 AM
A great (imo) update on this issue https://youtrack.jetbrains.com/issue/KT-12719. Another win of doing the right thing by default and allowing opt-in for the alternative in some way , like the decision was made for when statements to be exhaustive by default (annotation here, else -> in when statements). But Roman also said that this probably isn’t gonna happen anytime soon “we just don’t have short-term resources to execute it” so I wouldn’t hold my breath waiting.
b

bod

05/19/2022, 10:02 AM
oh yeah I saw this! Too bad this is for later - we need this NOW 😛 in related news, yesterday I took a look at making it a runtime error to not assign a field in the test builders dsl. This should be in the next release.
s

Stylianos Gakis

05/19/2022, 10:05 AM
Wow you fellows are too fast on fixing everything, I can’t keep up 😅
😄 1
Hey, tried out the snapshot, and just wanted to let you know, there is some code with compilation errors that gets generated: It’s such a silly reason, I would’ve totally expected this to work but I guess the way the code is parsed it doesn’t. So the problem is from the final return type being put after the
return
keyword, on the next line, showing it off as
Unreachable code
, and the return keyword with “This function must return a value of type Map<String, Any?>” Aka the code is parsed wrong, and this is one of the few cases where I guess it’d work if Kotlin had semicolons right 😂 In one of my test builders, this is generated:
public
    fun additionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetails(block: AdditionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetailsBuilder.() -> Unit
    = {}): Map<String, Any?> {
  __shouldBeAssignedFields.add("submitAdditionalPaymentDetails")
  return
      AdditionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetailsBuilder().apply(block).build()
}
while what should’ve been generated and would work is this
public
    fun additionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetails(block: AdditionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetailsBuilder.() -> Unit
    = {}): Map<String, Any?> {
  __shouldBeAssignedFields.add("submitAdditionalPaymentDetails")
  return AdditionalPaymentsDetailsResponseFinishedSubmitAdditionalPaymentDetailsBuilder().apply(block).build()
}
b

bod

05/20/2022, 11:39 AM
wow I think this formatting is done automatically by KotlinPoet and probably due to the long identifier which now makes the line longer than whatever its max line length is! But yes I'm surprised at the Kotlin compiler not liking this here 🤔
s

Stylianos Gakis

05/20/2022, 11:43 AM
Is this pure KotlinPoet formatting? Is there no formatter or something that passes through the generated code on the apollo-kotlin side? If so I guess this is a problem for them to solve, and it should be reported, but I would be very surprised if they hadn’t caught this before. It seems like it is something that can happen very easily with such long names
b

bod

05/20/2022, 11:44 AM
yes this is purely KotlinPoet but there's actually a fix: you can use non breaking spaces in the code specification 🙂
so that's missing in this case, I can make a quick fix 🙂
s

Stylianos Gakis

05/20/2022, 11:47 AM
Big brain solution 🧠 Nice thank you a lot 🙌
👍 1
Btw this makes me thing, this would make me at least a bit paranoid. Like having to add the special spacing character instead of normal space in every place where such code is generated. Is this what you’re gonna do now, or just for this specific case? I am not sure what’s best practice when using KotlinPoet
b

bod

05/20/2022, 12:04 PM
haha good thinking! I was about to add it in most
return
cases. We've been using the character in some places but not all...
🥴 1
s

Stylianos Gakis

05/20/2022, 12:07 PM
Such is the life of a Kotlin Poet I suppose 🧑‍🎨
b

bod

05/20/2022, 12:08 PM
hahaha 😄 well said
here we go
s

Stylianos Gakis

05/20/2022, 12:20 PM
Thanks a lot, again 🥳
b

bod

05/20/2022, 12:20 PM
happy to help!