Hey got a potential bug, don’t have a nice reprodu...

# apollo-kotlin

[Stylianos Gakis]

Hey got a potential bug, don’t have a nice reproducible build atm to show you, but I can ask it to see if from the top of your head you know that something changed in that part of the code, if not I can try and get something to show you.

Using testBuilders, I get generated code that is red. Specifically on a generated file, a testBuilder on a enum turned into a sealed class.

Got an enum like enum CrossSellType {FOO \n BAR} . Apollo {} is configured with sealedClassesForEnumsMatching.set(listOf("CrossSellType", ...)) and then the generated code looks like this "type" to resolve("type", CrossSellType.type.notNull(), knownValues().map { it.name }), .
Problem is, knownValues() returns a list of <CrossSellType> which is in fact a sealed class now, not an enum, so .name isn’t resolving, it’s red.

On Apollo 3.3.0 rn, can’t really test earlier versions as a lot of other things will be red.

[Stylianos Gakis]

And yes, removing the type from sealedClassesForEnumsMatching does produce a TestBuilder without errors.

[bod]

👀 let me see if I can reproduce it!

[bod]

yes I can

[bod]

I guess rawValue should be used in that case

[bod]

or in all cases actually

[Stylianos Gakis]

Yeah good point rawValue is available for the Enums as well

[bod]

Thanks a lot for finding and reporting it! 🙏

A fix is here. Unfortunately in the meantime I can't think of a workaround (except of course keeping generating an enum).

[Stylianos Gakis]

Amazing, thank you so much! I guess this is a perfect time I can try using a snapshot for the first time. How often are those generated? I see the latest snapshot was at "Wed May 18 184859 UTC 2022". Not sure if this fix is included in there, if not, how often is that generated?

[bod]

Oh yeah they're pushed as soon as a branch is merged on the main branch, so they should be available.