hey related to my colleague question

Question

hey related to my colleague < Sam Michael> question we are running into the mismatch issue which seems a bit more troubling since the hashing algorithm by default will generate a query hash exactly on how the query is done immediately there is a mismatch between that has for APQ and operation safelisting If the query keys are not alphabetically sorted with ` typename` first the two hashes used will never match up

agrosner · Answer

the solve would be to try to override the `operationIdGenerator` to match the way the safelisting generation works

agrosner · Answer

```mapOf signature to document safelistingHash document to document ``` in RegisterOperations kt

mbonnin · Answer

I m confused APQ and safelisting do not have to use the same hashes Is that the problem

mbonnin · Answer

Im no server expert but my understanding is that they have completely different paths on the server

mbonnin · Answer

So it should be fine to have one hash for APQ and a different one for safelisting

agrosner · Answer

right maybe what im asking is that since safelisting changes the query sent up by normalizing it wouldnt that break the client implementation sending the wrong query to the API

agrosner · Answer

or am i misunderstanding how safelisting works

agrosner · Answer

<https github com apollographql server plugin operation registry blob fbf727003ba407b9103d5c4a88579c04b38bf91e src ApolloServerPluginOperationRegistry ts L154|https github com apollographql server plugin operation registry blob fbf727003ba 5c4a88579c04b38bf91e src ApolloServerPluginOperationRegistry ts> so i see it normalizes the query for you on the server

mbonnin · Answer

I m no safelisting expert but I d say safelisting is only used for validation of the query The actual query being executed is the one sent by the client

mbonnin · Answer

Are you getting a specific error Maybe we can start from there

agrosner · Answer

actually thank you for your help it was all related to <https github com apollographql apollo kotlin releases tag v3 2 0> with addition In addition it introduces a `addTypename` Gradle option to have better control over when to add the ` typename` field

agrosner · Answer

the server was injecting the ` typename` always into our query while FE was not by upgrading and using the `always` option it fixed

mbonnin · Answer

Oh the server adds ` typename` when computing the hash

agrosner · Answer

sorry our server tool that runs apollo register for us the server was doing the right thing

mbonnin · Answer

Ahh yea gotcha thumbsup

mbonnin · Answer

I d strongly recommend using the `registerOperations` Gradle task though as even with `addTypename = always ` there might be some discrepencies between what `apollo kotlin` is doing and what `apollo cli` is doing

mbonnin · Answer

With `registerOperations` you re guaranteed that the input to the hashing algorithm is matching 100 what Apollo Kotlin is sending over the wire

Sam Michael · Answer

Thanks yes we are working on convincing our graphql team to allow us a way to use API key since currently we do not have permission

mbonnin · Answer

I see

mbonnin · Answer

Does your register tool run in Github actions by any chance

Sam Michael · Answer

It is a Node Package that wraps over Apollo CLI i believe

mbonnin · Answer

If they can run Kotlin you can register without Gradle pretty easily

mbonnin · Answer

Ah yea They re most likely not super keen on installing a JVM + Kotlin then I guess

mbonnin · Answer

I was thinking I could send you a small `register main kts` script that takes the Gradle plugin logic and that could run anywhere

mbonnin · Answer

Github actions has Kotlin installed by default so it s pretty convenient

Sam Michael · Answer

< agrosner> cc thanks Martin we should look into some alternative if there is still a danger of mismatches even with always config

mbonnin · Answer

Hopefully that won t be needed crossed fingers But it s hard to tell 100 due to the different codebases If you ever witness a mismatch let us know and we can maybe add `addTypename = sameAsApolloCli `