Hi, I received the following duplication error for Apollo generated types, wondering where to add th...

# apollo-kotlin

[Sam Michael]

Hi, I received the following duplication error for Apollo generated types, wondering where to add the 'alwaysGenerateTypesMatching' config?
Execution failed for task ':checkServiceApolloDuplicates'.

duplicate Type 'ResolverKey(kind=SchemaType, id=Query)' generated in modules: Somthing,SomethingElse

Use 'alwaysGenerateTypesMatching' in a parent module to generate the type only once

[Sam Michael]

Found it in the docs: https://www.apollographql.com/docs/kotlin/advanced/multi-modules/
// shared/build.gradle.kts
apollo {
// For an example if ReviewInput clashes
alwaysGenerateTypesMatching.set(listOf("ReviewInput"))
// You can also pass Regex patterns
alwaysGenerateTypesMatching.set(listOf(".*Input"))
}

[Sam Michael]

Hmm, wait still getting a gradle error, probably have to change example for groovy language build file maybe?

[Sam Michael]

alwaysGenerateTypesMatching.set(["Query"])

in parent module build file in apollo {} block seems to be working

[mbonnin]

Yep, good catch. We'll add the code sample for groovy

[mbonnin]

https://github.com/apollographql/apollo-kotlin/pull/3821

[Sam Michael]

Sorry to be back again for more, but having some issues still, thought it was fixed.

Basically we have two different POC's going on in our App in two different modules, both using the same schema. I tried suppressing the type generation but still failing the ':checkServiceApolloDuplicates' gradle task. I guess maybe because there is no parent module, they are both totally separate, so there is no correct module to suppress from. I tried also registering as separate services as I saw you suggest in another issue: https://spectrum.chat/apollo/apollo-android/apollo-multi-module-with-multiple-apps-in-a-project~eaa042ad-49db-470e-b044-d5423891ad70

What is the best way to have 2 separate services using apollo in the same project? Thanks

[mbonnin]

Hey ! No need to apologize for sending feedback 🙂 . This is super helpful!

[mbonnin]

About the issue, did you give 2 different names to your services?
module1:

apollo {
  service("service1") {
    packageName.set("com.service1")
  }
}

module2:

apollo {
  service("service2") {
    packageName.set("com.service2")
  }
}

[Sam Michael]

I tried but gradle sync kept failing, let me try again like your example above

[Sam Michael]

Went back to trying all as part of default service (since they are all using same schema):

Still getting this error, which is weird because I am doing the same thing with my new child module as was being done before with another child module

Multiple schemas found:

Use different services for different schemas
// core

apollo {
package.set(“core”)
generateKotlinModels.set(true)
generateApolloMetadata.set(true)
}

// child1

apolloMetadata(“core”)

apollo {
package.set(“child1)
} 

// child2

apolloMetadata(“core”)

apollo {
package.set(“child2”)
}

[mbonnin]

Wrap everything under a service {} block

[mbonnin]

What you're doing is using the default service in all modules there

[Sam Michael]

Oh okay, but I wonder why it was working before with just one child

[Sam Michael]

Adding another one seemed to break it

[mbonnin]

Ah sorry, I missed the part where you explicitly wanted to use the default service

[mbonnin]

Do you have multiple schema files in your tree?

[mbonnin]

If yes you can specify the one you want with schemaFile.set()

[Sam Michael]

I have another schema file in top level but it wasn't causing an issue before with just the two modules before, adding a third now it says i have multiple schemas

[Sam Michael]

Definitely can try schemaFile.set(), do I do in all the modules or just parent

[Sam Michael]

We are transitioning from our old endpoint to a new federated graphql service, along with apollo client

[Sam Michael]

but the legacy graphql service shouldn't be detected by apollo plugin at all i dont think

[Sam Michael]

since schema for that is in the root of the project folder

[Sam Michael]

Thanks again for all your help!

[mbonnin]

schemaFile.set() should be in the core module if you're using multi module

[mbonnin]

Also, package is suspicious. It should be packageName iirc

[Sam Michael]

whoops think that is a typo in trying to copy over and anonymize

[mbonnin]

Also Iirc, the 'multiple schema files found' error should list the files found

[mbonnin]

(i'm on mobile right now but can double check when back at the computer)

[mbonnin]

(back at the computer) So yea, since everything shares the same schema, I think it makes sense to use multi-module but it's hard to tell without more context. If you're doing a migration, maybe you'd be better of generating duplicate classes under a different package name and migrating progressively

[mbonnin]

In all cases, the "multiple schema" error should go away with schemaFile.set()

[Sam Michael]

I must be a problem child, I am still getting that error even after setting schemaFile
would it be better if I combine all the schemas with list of all the schemas?
schemaFile.set(listOf("schema1, schema2, schema3"))

[mbonnin]

Interesting. Let's take things one after the other. First question is: how come you have different schemas?

[Sam Michael]

Good question, We have different graphql services and endpoints, a legacy one, a federated one, and a one for favoriting things.

[mbonnin]

So all these endpoints have different types, right?

[mbonnin]

Even if they share "some" business logic

[Sam Michael]

May be some overlap, since a lot of the monolith/legacy service is being migrated to federated. some by proxy, some reimagined

[mbonnin]

In all cases, different endpoints means different services for apollo so you should certainly use different services

[Sam Michael]

Well, for now we are using our retrofit client with the others, but moving to apollo-kotlin for the new federated service

[Sam Michael]

the schema files prior to apollo-kotlin readoption are mostly there for js-graphql plugin to work

[mbonnin]

Sounds good 👍

[Sam Michael]

So all could technically be one apollo "service", but I am messing something up in the config I guess

[Sam Michael]

Before we had a core module, and one test pilot module with a single query, I am adding another example from my team, but getting stuck

[mbonnin]

Exactly, looks like you need only one apollo "service" (for the federated endpoint)

[mbonnin]

Why not put the query in the "core" module?

[Sam Michael]

Yeah, that is a good point, that was a mistaken example I was following I guess, the other team did it that way

[Sam Michael]

and just force of habit I guess

[mbonnin]

It's usually just easier to start with a single module

[mbonnin]

The multi-module apollo support (as in https://www.apollographql.com/docs/kotlin/advanced/multi-modules/) is interesting when your build grows and you want independant modules to save some build time

[mbonnin]

But if you're starting up, I'd recommend sticking with a single module

[Sam Michael]

That unfortunately is not possible due to our team structure and scale

[mbonnin]

I mean a single module where the apollo plugin is applied

[Sam Michael]

Ah yes, my bad

[mbonnin]

Nono sorry, that wasn't clear

[Sam Michael]

So let me try removing the plugin from the 2 children

[mbonnin]

You can have a build with 1000 Gradle modules but you're always going to add the first query to one of these modules

[mbonnin]

So you can choose this module to apply the "com.apollographql.apollo3" plugin

[mbonnin]

And add a simple configuration there:

apollo {
   packageName.set("com.example")
}

[mbonnin]

(no apolloMetata, no generateApolloMetadata, this can all come later)

[Sam Michael]

And then the other modules don't need to have apollo configurations like apollo {} at all?

[mbonnin]

They shouldn't need anything indeed

[mbonnin]

Not as long as you don't generate any code in those other modules

[mbonnin]

You might want to do this later but usually this is not required until you have a lot of queries

[mbonnin]

Assuming the module you want to add your first query to is named "feature1", you can add the schema in your module:

feature1/src/main/graphql/schema.json

and your first query:

feature1/src/main/graphql/MyQuery.graphql

[mbonnin]

And then generate code:

./gradlew :feature1:generateApolloSources

(or hit the play button in Android Studio)

[Sam Michael]

Shoot, now I see the way we built our architecture I don't think it lets me move the queries into the feature1 module. So confused

[Sam Michael]

Or maybe just my computer overheating and build files are all scrambled and I should take a break lol, life of an android developer

[mbonnin]

"Invalidate caches and restart" 😅

[mbonnin]

I don't think it lets me move the queries into the feature1 module

Not sure I understand. You already have multiple queries? Where are they coming from ? The retrofit implementation you were mentioning before?

[mbonnin]

I thought this was a "new" implementation using the federated schema so that you'd have to write new queries for this endpoint

[Sam Michael]

There is already 1 other team that started ahead of me and made a module with 1 query, so I was trying to emulate their pattern

[mbonnin]

Ah ok

[mbonnin]

Then yea, if you want multi-module already, you'll have to go through the hoops of generateApolloMetadata and apolloMetadata

[mbonnin]

First thing you'll have to do is to create the "core" module and make that other team module use it

[Sam Michael]

Yes, we have a core module already

[mbonnin]

Is this the module with the query?

[mbonnin]

(from the other team ?)

[Sam Michael]

yes

[mbonnin]

But I'm assuming you don't want your query to go inside that module?

[mbonnin]

(that would be much easier to start with)

[Sam Michael]

Yes, well i am trying with all the queries in core and I still can't get it to work

[mbonnin]

What is the error you're getting?

[mbonnin]

If there's one query and it's working, you should be able to add a second .graphql file next to the first one without even touching the Gradle configuration

[Sam Michael]

Ok, I will try from scratch and just add our team's query next to team1's

[mbonnin]

👍 let me know how that goes

[Sam Michael]

Thank you Martin, you're the best!

[mbonnin]

Sure thing!