https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
s

Stylianos Gakis

01/11/2022, 9:25 AM
Could any guidance be added for interceptors, but not for Http ones as described here, but adding a section about ApolloInterceptor too. More in Thread 🧵
For example now during migration, I’m looking into changing an interceptor I had here and it doesn’t feel like a simple 1-to-1 mapping (or I’m just lacking some knowledge on how to do it). Would the normal pattern be doing a map on the flow? Something like?
override fun <D : Operation.Data> intercept(
  request: ApolloRequest<D>,
  chain: ApolloInterceptorChain,
): Flow<ApolloResponse<D>> {
  return chain.proceed(request).map { response ->
    if (notAplicableHere) return@map response // If nothing to intercept just return it as it was
    // do something else with the response if applicable
    response // ^map return the response as it was if we reached the end of the map
  }
}
And in my case where I just want to do something but not edit the response itself maybe doing an
onEach
is what I should look into?
...
  return chain.proceed(request).onEach { response ->
    if (response.notApplicablehere) return@onEach
    //do something
  }
I am now thinking this may have more to do with me not fully understanding how this flow chain would work, but I am pretty sure more people will have the same doubts so some guidance would be really appreciated (unless it’s in the docs and I missed it?)
b

bod

01/11/2022, 9:46 AM
Hi! Yes what you said is correct. Another equivalent way to do it in the case where it’s not applicable would be to return immediately like:
override fun <D : Operation.Data> intercept(
  request: ApolloRequest<D>,
  chain: ApolloInterceptorChain,
): Flow<ApolloResponse<D>> {
  if (notAplicableHere) return chain.proceed(request)
  return chain.proceed(request).onEach { response ->
    // your custom logic
  }
}
👌 1
there’s also an instance of an Interceptor used internally (for the Auto Persisted Query feature) that you can have a look at here for an example
but you’re right that we have a doc for Http Interceptors but not for Apollo ones - maybe we ought to add one with a small example 🙂
s

Stylianos Gakis

01/11/2022, 10:14 AM
The example you linked is perfect, I just needed to see it somewhere being done correctly so I can draw some inspiration and stop making assumptions that I wouldn’t know are true. A small example just with a working snippet and a couple of words on how this should work would be perfect. As a side note, this wasn’t mentioned in the migration docs either, but there are some differences that maybe deserve a section? There is no longer a
ApolloInterceptorFactory
which was added with
addApplicationInterceptorFactory
, now we just add the interceptor itself, which makes me wonder if will this have any different behavior? This migration process has me at the moment with the entire project being red pretty much and I can’t start testing what I am migrating until I get the project to build again, so I’m having a hard time knowing if what I’m doing is correct or not yet 😅
m

mbonnin

01/11/2022, 10:17 AM
I was somewhat hoping that the
Flow
introduction would simplify enough that the API would speak for itself but indeed coroutines API do change a lot of things...
Maybe we could add backward compatibility helpers for interceptors too to simplify a bit the migration?
In this specific case, I think the interceptor can be reduced to:
class SunsettingInterceptor: ApolloInterceptor {
  override fun <D : Operation.Data> intercept(request: ApolloRequest<D>, chain: ApolloInterceptorChain): Flow<ApolloResponse<D>> {
    return chain.proceed(request).onEach {
      if (it.errors?.any { it.isSunsetError() } == true) {
        ForceUpgradeActivity.newInstance(context)
      }
    }
  }

  private fun Error.isSunsetError(): Boolean {
    return nonStandardFields?.get("errorCode") == "invalid_version"
  }
}
❤️ 1
s

Stylianos Gakis

01/11/2022, 10:29 AM
It definitely makes things nicer, it’s just that not everyone (me included) is 100% confident in all things coroutines if that makes sense so I needed a hint at least. A backwards compatible interceptor to ease migration would be very nice for people who might have a ton of them, we just had one so it’s better to actually understand what has changed and do it by hand. Has anyone else asked about them before? Maybe people aren’t struggling with migrating them as much as I did. And thanks a lot for the last snippet, that’s exactly what I ended up with myself after the suggestions Benoit gave me, so I think this also speaks to the simplicity that you mentioned before.
👍 1
❤️ 1
m

mbonnin

01/11/2022, 11:12 AM
I opened https://github.com/apollographql/apollo-kotlin/issues/3785 so we can keep track of the backward compat helper. The issue is that the 2.x interceptors will put the
Callback
API, maybe some other stuff so it might end up pulling a lot of code but it's worth exploring
🙏 1