Something changed between v3 0 0 dev14 and v3 0 0 alpha01 th kotlinlang #apollo-kotlin

Something changed between v3.0.0-dev14 and v3.0.0-alpha01 that is now causing one of my mutations to never return. I'm looking into it more but thought I would post this in case it rings a bell with anybody involved in making those changes.

mbonnin

07/27/2021, 3:46 PM

Is this on JVM or Apple ?

Doug Chappelle

07/27/2021, 3:47 PM

Android, so I would assume JVM

mbonnin

07/27/2021, 3:48 PM

Yup, Android is JVM

Is this using a WebSocketNetworkTransport? or regular HttpNetworkTransport?

Doug Chappelle

07/27/2021, 3:49 PM

WebSocketNetworkTransport

👍 1

mbonnin

07/27/2021, 3:49 PM

Alright. Yep, there have been a few changes around this

Maybe https://github.com/apollographql/apollo-android/pull/3214 ?

Mmm no that mainly touches AppSync

The other candidate would be https://github.com/apollographql/apollo-android/pull/3217

Doug Chappelle

07/28/2021, 6:40 PM

And the winner is... https://github.com/apollographql/apollo-android/pull/3220

👀 1

mbonnin

07/28/2021, 6:57 PM

Oh wow that's interesting.... I wouldn't expect this to do anything with mutations.

I'm afk right now but will dig a bit more later today

Doug Chappelle

07/28/2021, 7:00 PM

np, thx

mbonnin

07/28/2021, 9:53 PM

This PR is relatively small. The only thing that could maybe explain a behaviour change is the change from

flatMapLatest

flatMapConcat

(here).

Doug Chappelle

07/28/2021, 9:56 PM

When I get a chance I'll try changing it back and see what happens... get some sleep

:thank-you: 1

mbonnin

07/28/2021, 9:56 PM

Thanks!

IIRC, this was made so that emissions from the ApolloCacheInterceptor would not suspend (so that we can check the cache status just after receiving the response, else receiving the response is always delayed to after potentially writing the cache)

So this changes the supension points.

flatMapLatest

is introducing an intermediate channel that maybe prevents a deadlock or something like this

Going to sleep too, have a good night!

👍 1

4 Views

#apollo-kotlin Join Slack