Was just pleasantly surprised to see that `Modifier.scroll` seems to automatically keep the focused ...

# compose-desktop

[Alexander Maryanovsky]

Was just pleasantly surprised to see that Modifier.scroll seems to automatically keep the focused element in view. Very nice.

[Zach Klippenstein (he/him) [MOD]]

Sometimes 😜 we're still working on some “edge” cases

[Alexander Maryanovsky]

Is there a way to ask for it to scroll a bit more than the necessary minimum such that element is not only visible, but slightly more “inside” the scrollable container? I could give it extra padding, but that would affect the layout, which I don’t want.

[Zach Klippenstein (he/him) [MOD]]

You could use your own BringIntoViewRequester and make the request on focus with a larger rect than the size of the field. I haven’t tried that but i think it should work

[Alexander Maryanovsky]

Is BringIntoViewResponder not in compose-desktop yet? It seems like the better way to go is to implement BringIntoViewResponder.calculateRectForParent to return a slightly larger rect.

[Alexander Maryanovsky]

Hmm, I see BringIntoViewResponder but not Modifier.bringIntoViewResponder

[Alexander Maryanovsky]

Also, my own BringIntoViewRequester doesn’t work, because the “built-in” mechanism calls scrollableState.animateScrollBy immediately after my BringIntoViewRequester does so, which overrides my scroll request.

[Alexander Maryanovsky]

It does work if I put delay(1) before calling bringIntoViewRequester.bringIntoView

[Zach Klippenstein (he/him) [MOD]]

Does your requested rectangle include the whole field? Overlapping concurrent requests should be merged

[Alexander Maryanovsky]

It does:

.onGloballyPositioned {
    layoutCoords = it
 }
.bringIntoViewRequester(bringIntoViewRequester)
.onFocusChanged {
    if (it.isFocused) {
        layoutCoords?.size?.let { size ->
            coroutineScope.launch {
                delay(1)
                val rect = size.toSize().toRect()
                val targetRect = rect.copy(top = <http://rect.top|rect.top> - 20, bottom = rect.bottom + 20)
                bringIntoViewRequester.bringIntoView(targetRect)
            }
        }
    }
}

[Alexander Maryanovsky]

I don’t see them being merged. I just put a breakpoint in BringIntoViewResponder.performBringIntoView and it’s called twice - once from my call (with the correct rect) and once from somewhere else (with the default rect).

[Alexander Maryanovsky]

and since all it does is call

scrollableState.animateScrollBy(offset.reverseIfNeeded())

it’s not surprising that the 2nd call “cancels” the first call.

[Zach Klippenstein (he/him) [MOD]]

No, the merging happens somewhere else. What version of compose is this?

[Alexander Maryanovsky]

id("org.jetbrains.compose") version "1.1.1"

[Zach Klippenstein (he/him) [MOD]]

Oh yea, all of these fixes are only in 1.2