Anyone notice `Popup`s now have a fixed size? I up...

# compose-desktop

[Dominaezzz]

Anyone notice `Popup`s now have a fixed size? I upgraded a compose desktop project from beta5 to rc3 and all my popup sizes are off.

[Igor Demin]

Can you provide a snippet, where the popup's size is wrong?

Between rc5 and beta5 there was one change regarding popup size - the default constraints passed to popup are max(availableSpaceBelowPopup, availableSpaceAbovePopup) instead of windowHeight.

[Dominaezzz]

singleWindowApplication(
    state = WindowState(size = DpSize(300.dp, 300.dp)),
    title = "Chit Chat"
) {
	MaterialTheme {
		Popup(
			alignment = Alignment.Center,
		) {
			Card(Modifier.fillMaxSize(0.7f)) {
				Box(contentAlignment = Alignment.Center) {
					Text("Testing!", Modifier.wrapContentSize())
				}
			}
		}
	}
}

[Dominaezzz]

The size of the popup isn't 0.7f of the whole window.

[Dominaezzz]

It seems to want Modifier.required*() to make it respect any size parameters passed in.

[Dominaezzz]

I also can't click on buttons in my popups anymore.

[Dominaezzz]

I'll create a better reproducer when I get a moment.

[Igor Demin]

To fix the issue, wrap your popup into Box(Modifier.fillMaxSize()):

import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.wrapContentSize
import androidx.compose.material.Card
import androidx.compose.material.ExperimentalMaterialApi
import androidx.compose.material.MaterialTheme
import androidx.compose.material.Text
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.window.Popup
import androidx.compose.ui.window.Window
import androidx.compose.ui.window.application

@OptIn(ExperimentalMaterialApi::class)
fun main() = application {
    Window(onCloseRequest = ::exitApplication) {
        MaterialTheme {
            Box(Modifier.fillMaxSize()) {
                Popup(
                    alignment = Alignment.Center,
                ) {
                    Card(Modifier.fillMaxSize(0.7f)) {
                        Box(contentAlignment = Alignment.Center) {
                            Text("Testing!", Modifier.wrapContentSize())
                        }
                    }
                }
            }
        }
    }
}

I will investigate, if it is expected behavior.

[Dominaezzz]

Thanks!

[Igor Demin]

Behavior is probably correct.

alignment = Alignment.Center

means that the center of Popup should be in the center of the parent component.

The parent component by default is an empty box with (0, 0) coordinates.

[Dominaezzz]

When you say empty box, do you mean no children? Or zero width and height?

[Igor Demin]

Zero width and height

[Dominaezzz]

Box(Modifier.fillMaxSize().background(Color.Cyan)) {
	Popup(
		alignment = Alignment.Center,
	) {
		Card(Modifier.fillMaxSize(1f)) {
			Box(contentAlignment = Alignment.Center) {
				Text("Testing!", Modifier.wrapContentSize())
			}
		}
	}
}

[Dominaezzz]

Why doesn't the popup fill the entire window?

[Dominaezzz]

It's like the height and width being passed down to the popup is being halved.

[Dominaezzz]

Or rather, the parent is only reporting halve (or a quarter if you want to be pedantic) the available space.

[Dominaezzz]

Interesting, passing other alignments yields different sizing behaviour.

[Dominaezzz]

Center halves both dimensions, CenterStart and CenterEnd halves the height, CenterVertically halves the width.

[Dominaezzz]

Looks like centring is broken somewhere.

[Igor Demin]

That is probably not correct behavior. I created an issue, we will look tomorrow.

[Igor Demin]

Clicks are broken 😞

[Dominaezzz]

Aww shame

[Dominaezzz]

Thanks for filling!

[Igor Demin]

But good news, I already fixed them

[Dominaezzz]

Oh wow nice!

[Dominaezzz]

Also, does that mean I can make PRs to your androidx repo instead of Google's?

[Igor Demin]

If you fix a bug before 1.0 - yes, you can make a PR to our fork (probably we should give you access)

After 1.0 we haven't yet establish the process. Probably the old process will stay - all new features/fixes should be merged to aosp first.

[Dominaezzz]

Ah good to know.

[Colton Idle]

I feel 1.0 coming really soon!