A modern programming language that makes developers happier.

kotlinlang

<@U015TKX93PD> - I just upgraded to build 396, and looks like the version of `ComposeWindow` that gets parent composition is gone. But it's still there in <https://github.com/androidx/androidx/blob/androidx-main/compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeWindow.desktop.kt#L85>. Is there a different branch that 396 is cut from, and if so, what is the new way to propagate all composition locals from the parent window to the new window?

&gt; Is there a different branch that 396 is cut from
We build from <https://github.com/JetBrains/androidx/tree/jb-main>, which contains a new API, that is not yet merged to androidx (we mark it as Experimental), and several bugfixes.

&gt; that gets parent composition is gone
Use <https://github.com/JetBrains/androidx/blob/ed1fc5d9781fb7a5f5bc5179002935a18a18f672/compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/Window.desktop.kt#L311|currentCompositionLocals>. It is not a final API though, and probably will be changed soon.

We rushed to change it because of the very ugly bug with high <https://github.com/JetBrains/compose-jb/issues/1054|CPU usage>. Parent composition doesn't work well if we pass it from `application` to `Window` or from `Window` to `Window` (it provides a wrong frame clock), and we decide to remove it from API, until we figure out how to properly fix it (a proper fix isn't trivial)

Resurrecting this, <@U015TKX93PD>. In build 418 I get `Unresolved reference: currentCompositionLocals`

Yeah, it was changed again to this:
```val currentLocalContext by rememberUpdatedState(currentCompositionLocalContext)

...

CompositionLocalProvider(currentLocalContext ) {
    ...
}```
It was the last breaking change, as it was merged to aosp )

Ah, thanks. This was an easy one - <https://github.com/kirill-grouchnikov/aurora/commit/80221fbf7c5deb927e36fc764d300d157629d2a1>

I was looking at the `Window.desktop.kt` sources in `JetBrains/androidx` for reference, but they are still in the "old" world

you can look <https://github.com/JetBrains/androidx/tree/release/1.0-beta|here>

<@UHED82QLX>

News about this feature. If we pass locals not at the top level, we override some important locals.

I made <https://github.com/JetBrains/androidx/pull/71/files#diff-7a205e615364664297d030c678597dd1730f6c72d27b2713abb94638b7dd3db2|a fix> in Compose (instead of using `CompositionLocalProvider` directly, use `window.compositionLocalContext =`)

Suggest do the same in Aurora :slightly_smiling_face:

Thanks! Done <https://github.com/kirill-grouchnikov/aurora/commit/a9f9e3e9f9948fdbfa834737c2ba8e9965b27c0f|over here>.