<@U015TKX93PD> - I just upgraded to build 396, and looks like the version of `ComposeWindow` that ge...

# compose-desktop

[Kirill Grouchnikov]

@Igor Demin - I just upgraded to build 396, and looks like the version of ComposeWindow that gets parent composition is gone. But it's still there in https://github.com/androidx/androidx/blob/androidx-main/compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeWindow.desktop.kt#L85. Is there a different branch that 396 is cut from, and if so, what is the new way to propagate all composition locals from the parent window to the new window?

[Igor Demin]

Is there a different branch that 396 is cut from

We build from https://github.com/JetBrains/androidx/tree/jb-main, which contains a new API, that is not yet merged to androidx (we mark it as Experimental), and several bugfixes.

that gets parent composition is gone

Use currentCompositionLocals. It is not a final API though, and probably will be changed soon.

We rushed to change it because of the very ugly bug with high CPU usage. Parent composition doesn't work well if we pass it from application to Window or from Window to Window (it provides a wrong frame clock), and we decide to remove it from API, until we figure out how to properly fix it (a proper fix isn't trivial)

[Kirill Grouchnikov]

Thanks, this works

[Kirill Grouchnikov]

Resurrecting this, @Igor Demin. In build 418 I get Unresolved reference: currentCompositionLocals

[Igor Demin]

Yeah, it was changed again to this:

val currentLocalContext by rememberUpdatedState(currentCompositionLocalContext)

...

CompositionLocalProvider(currentLocalContext ) {
    ...
}

It was the last breaking change, as it was merged to aosp )

[Kirill Grouchnikov]

Ah, thanks. This was an easy one - https://github.com/kirill-grouchnikov/aurora/commit/80221fbf7c5deb927e36fc764d300d157629d2a1

[Kirill Grouchnikov]

I was looking at the Window.desktop.kt sources in JetBrains/androidx for reference, but they are still in the "old" world

[Igor Demin]

you can look here

[Igor Demin]

@Kirill Grouchnikov

News about this feature. If we pass locals not at the top level, we override some important locals.

I made a fix in Compose (instead of using CompositionLocalProvider directly, use window.compositionLocalContext =)

Suggest do the same in Aurora 🙂

[Kirill Grouchnikov]

Thanks! Done over here.