When going from compose android to compose I can r...
# compose-desktop
c
When going from compose android to compose I can remove this buildFeature compose = true flag... right?
Copy code
buildFeatures {
        buildConfig = true
        compose = true
        viewBinding = true
}
i
We haven't tested
org.jetbrains.compose
plugin with
compose = true
But it seems work. Theoretically there can be a version conflict. Because
compose = true
applies its own version of Compose Compiler plugin (kotlinCompilerExtensionVersion) that can be different from compiler plugin that is applied by
org.jetbrains.compose
But this property also adds some other features like preview in Android Studio and (probably, not sure) icons in the gutter.
👍 2
c
Thanks. Again my perspective on this is that I'm trying to submit a diff with as minimal changes as possible to show my team "hey these are the only things that are changing". My team is a little weary that jetbrains compose is somehow a different version of compose... but from what I can tell jb compose is basically a 1:1 with android compose https://github.com/JetBrains/compose-jb/blob/master/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposePlugin.kt#L63
// It is needed, because 'org.jetbrains.compose' artifacts are the same artifacts as 'androidx.compose'
My team is happy to hear that the artifacts are the same its just the package name that's different.
i
is basically a 1:1 with android compose
Yes, in terms of code it should be identical in android. JB android artifacts just built from a different revision, with a different flag (mppSupport=true) and published by different maven coordinates.
One note. Because currently we build artifacts from a different revision (the latest
androidx-main
revision) they can be unstable in compare to stable
androidx
artifacts (for example, the future androidx 1.0.0)
c
JB android artifacts just built from a different revision, with a different flag (mppSupport=true) and published by different maven coordinates.
That's perfect! Exactly what I think will convince my team. We just wanted to make sure there wasn't some crazy changes being made. But if it's just a different revision, added mppSupport flag and different coordinates... that should convince them! Thank you again!
👍 1