There seems to be an issue with the `items` function in Lazy kotlinlang #compose-desktop

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

g

gbaldeck

05/31/2021, 9:30 PM

There seems to be an issue with the

items

function in LazyListScope. The item content is not re-rendering despite state change. Or perhaps I'm doing something wrong? here is the code https://github.com/recursivelftr/Grim-Locations/blob/master/src/main/kotlin/io/grimlocations/ui/view/component/LocationListComponent.kt#L52

j

John O'Reilly

05/31/2021, 9:41 PM

not sure if maybe this is variation of what I ran in to in https://kotlinlang.slack.com/archives/C01D6HTPATV/p1622220633211600

g

gbaldeck

06/01/2021, 12:47 AM

Seems very similar

I upgraded from an older build also and that's when it started happening

The issue happens intermittently, sometimes it re-renders and other times it doesnt\

I tried it using a foreach loop and the

item

function instead of

items

, same problem. This is a pretty major issue as there does not seem to be any work around

z

Zach Klippenstein (he/him) [MOD]

06/01/2021, 1:20 PM

It’s smelly to be using a

Set

for the input there. Ordering of elements within a set is not guaranteed. This means your key function could be unstable, and the order of rows in your list is undefined and could randomly switch between compositions.

g

gbaldeck

06/01/2021, 1:22 PM

I'll give it a try with a list and see if that fixes the issue

z

Zach Klippenstein (he/him) [MOD]

06/01/2021, 1:22 PM

It may not if there’s an underlying bug, but it would still be much better to use a list for this for the reasons I mentioned.

(If your actual set implementation is a linkedhashset, then you will get consistent ordering but that’s not guaranteed by the set contract).

g

gbaldeck

06/01/2021, 1:24 PM

it looks like kotlin does use linked hashset

for setOf and so on

z

Zach Klippenstein (he/him) [MOD]

06/01/2021, 2:18 PM

Yep still better to use a list for this though.

2 Views

#compose-desktop Join Slack