Is there any known animation issue with `0 4 0 build178` `an kotlinlang #compose-desktop

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

t

theapache64

03/30/2021, 2:29 PM

Is there any known animation issue with

0.4.0-build178

?

animateFloatAsState

doesn't seem to work anymore. 🤔 🧵

Reproducible Code: https://gist.github.com/theapache64/9dfa23d9f688112b9a51c1fe36de1271

FYI. The code was working in previous versions.

j

jim

03/30/2021, 6:20 PM

Looks like a (unintentional?) behavioral change in animations. Specifically, the

finishedListener

would previously run upon first composition allowing you to use

tween

+

finishedListener

to implement an infinite animation. It appears this is no longer the case. @Doris Liu WAI or bug?

I suspect this changed in https://android-review.googlesource.com/c/platform/frameworks/support/+/1627839

d

Doris Liu

03/30/2021, 6:30 PM

It's an intentional change to avoid unnecessary animations. Previously,

animateFloatAsState

would animate (from/to the same target) when it enters composition, and subsequently invokes the finished listener. Now it only animates when target changes.

👍 2

Looking at the code snippet, the previous behavior would have been no visible change (due to the same from/to value) for the first animation duration, then animating in-between the two target values. 🙂 I suspect that's not the desired behavior. If it's intended for the animation to start as soon as enters composition, consider putting an initial state toggle in a
DisposableEffect
[Edit:] using

Animatable

. Note, it's generally recommended to avoid writing compositions that take more than one pass to converge. Putting state toggle in

DisposableEffect

would therefore be an antipattern.

t

theapache64

03/30/2021, 7:14 PM

Understood. was this document anywhere in the release notes?

Yeah got it. Thanks @Doris Liu @jim

d

Doris Liu

03/30/2021, 7:17 PM

It wasn't in the release note, as we weren't expecting that behavior to be depended on. 😅

6 Views

#compose-desktop Join Slack