Hi guys, does anyone knows how to deal with distri...

# compose-desktop

[Marcin Środa]

Hi guys,
does anyone knows how to deal with distributable for macOs? I created a jar just for tests - it works fine. Now I tried to create a distributable, build is finished but due to gson dependency I’ve got :
Caused by: java.lang.ClassNotFoundException: java.sql.Time

Am I able to add this module to dmg?

[theapache64]

I had similar issue, but not with java.sql.Time but with java.logging. and I had to add modules("java.logging") inside nativeDistributions block. Similarly , there should be some module that'll add java.sql.Time to your build. am not sure if its similar to mine.

maybe @olonho can help here.

[olonho]

Try adding “java.sql” module, see https://docs.oracle.com/javase/9/docs/api/module-overview-frame.html for full list

[Marcin Środa]

Thank you guys, it works! Doesn’t know where to place module before 🙂

[theapache64]

https://twitter.com/theapache64/status/1367094725560258561

[jim]

@olonho Perhaps we can catch such problems at build time by performing some sort of verification step?

[jim]

I went ahead and created a bug to track this: https://github.com/JetBrains/compose-jb/issues/463

[olonho]

maybe, but guess instead of “we” it shall be jlink devs

[jim]

Yeah, probably that is true.

[jim]

Although, isn't the nativeDistributions block something we own/created? We would want an error message that makes it clear what the expected fix would be, including mentioning the nativeDistributions block which I think jlink would not know about.

[olonho]

yes, nativeDistributions is controlled by our plugin, maybe we could improve error handling somewhat, but feature seems to belong to jlink

[suresh]

jdk has a tool called jdeps for that purpose. Ideally build tools plugins will use jdeps and feed it’s output to jlink

[suresh]

https://docs.oracle.com/en/java/javase/15/docs/specs/man/jdeps.html

[suresh]

Here is the command that will print all the required modules for a jar

$ jdeps --print-module-deps --ignore-missing-deps build/libs/app-1.0.0-72.jar                                                    
java.base,java.compiler,java.desktop,java.net.http,jdk.httpserver,jdk.management.jfr

[suresh]

https://res.infoq.com/presentations/openjdk-containers/en/slides/sl17-1589893580942.jpg▾