what s the problem kotlinlang #ktfmt

Join Slack

what’s the problem?

# ktfmt

gammax

12/24/2020, 10:52 PM

what’s the problem?

Javier

12/24/2020, 10:52 PM

I break the code, example:

Javier

12/24/2020, 10:53 PM

I run ktfmtFormat, it is fixed. I break it again and I rerun ktfmtFormat, the gradle task is up to date when it should run

gammax

12/24/2020, 10:54 PM

Yeah, you’re creating sort of a “edge case” scenario tbh.

gammax

12/24/2020, 10:55 PM

As Gradle is using file hashes to compute the

UP-TO-DATE

state.

Javier

12/24/2020, 10:55 PM

I am going to try intellij idea

Javier

12/24/2020, 10:56 PM

mmmm but it is going to be something we could do a lot of times

gammax

12/24/2020, 10:56 PM

What do you mean?

gammax

12/24/2020, 10:56 PM

Anyway, you can

ktfmtFormat --rerun-tasks

and that will run the formatter all the times, skipping the

UP-TO-DATE

check.

Javier

12/24/2020, 10:57 PM

thank you, I am going to check it, and do some tests

👌 1

Javier

12/24/2020, 10:58 PM

Another example

Javier

12/24/2020, 10:59 PM

I run the task, it fixed all, I just add new code, and a part of this code is not well formatted, it doesn’t re-run. I think this can be a habitual scenario instead of just fix, break without adding nothing and try to fix

gammax

12/24/2020, 11:00 PM

☝️ this is odd.

Javier

12/24/2020, 11:00 PM

I have to check it in intellij too, because I think it is not happening there

gammax

12/24/2020, 11:01 PM

Like I have a test for exactly that scenario: https://github.com/cortinico/ktfmt-gradle/blob/19cf6285b3765ffa14e8c26713562facab3[…]com/ncorti/ktfmt/gradle/tasks/KtfmtFormatTaskIntegrationTest.kt

Javier

12/24/2020, 11:01 PM

give me a few minutes (intellij doesnt support agp 4.1.1…)

Javier

12/24/2020, 11:01 PM

are you using AS or IntelliJ?

gammax

12/24/2020, 11:01 PM

I’m on IJ

Javier

12/24/2020, 11:01 PM

yeah

Javier

12/24/2020, 11:01 PM

ktfmtFormat --rerun-tasks

Javier

12/24/2020, 11:01 PM

this even doesnt work

Javier

12/24/2020, 11:01 PM

the file keeps broken

Javier

12/24/2020, 11:02 PM

I created an issue yesterday about this in issuetracker, we can just wait

Javier

12/24/2020, 11:03 PM

are you using it with Android?

gammax

12/24/2020, 11:06 PM

yup

gammax

12/24/2020, 11:07 PM

If you can share a Gradle scan or a stacktrace would be great 👌

gammax

12/24/2020, 11:07 PM

Or even a reproducer.

gammax

12/24/2020, 11:08 PM

I’m afraid you applied the plugin also at the top level project and you end up calling an empty

ktfmtFormat

task that does nothing 🤔

Javier

12/24/2020, 11:08 PM

I am going to do more tests and if I dont fix it I will try to do a sample project

gammax

12/24/2020, 11:09 PM

Sweet 👌 Keep me posted

gammax

12/24/2020, 11:09 PM

Anyway, if you run the tasks with

--info

, I’ve added some logging with the

[ktfmt]

tag. So it should be easier to spot if work is happening or not.

Javier

12/24/2020, 11:12 PM

I am unable to use it with agp 4.0.1:

Copy code

Unable to find method ''org.gradle.api.NamedDomainObjectContainer com.android.build.api.dsl.CommonExtension.getSourceSets()''

😰 1

Javier

12/24/2020, 11:13 PM

Copy code

* Exception is:
java.lang.NoSuchMethodError: 'org.gradle.api.NamedDomainObjectContainer com.android.build.api.dsl.CommonExtension.getSourceSets()'
	at com.ncorti.ktfmt.gradle.KtfmtPlugin$applyKtfmtToAndroidPlugin$1.execute(KtfmtPlugin.kt:92)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin$applyKtfmtToAndroidPlugin$1.execute(KtfmtPlugin.kt:34)
	at org.gradle.internal.extensibility.ExtensionsStorage$ExtensionHolder.configure(ExtensionsStorage.java:173)
	at org.gradle.internal.extensibility.ExtensionsStorage.configureExtension(ExtensionsStorage.java:70)
	at org.gradle.internal.extensibility.DefaultConvention.configure(DefaultConvention.java:189)
	at org.gradle.internal.extensibility.DefaultConvention.configure(DefaultConvention.java:184)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin.applyKtfmtToAndroidPlugin(KtfmtPlugin.kt:89)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin.access$applyKtfmtToAndroidPlugin(KtfmtPlugin.kt:34)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin$applyKtfmtToAndroidProject$2.execute(KtfmtPlugin.kt:82)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin$applyKtfmtToAndroidProject$2.execute(KtfmtPlugin.kt:34)
	at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1.execute(DefaultUserCodeApplicationContext.java:100)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction$1.run(DefaultCollectionCallbackActionDecorator.java:95)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:56)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$run$1(DefaultBuildOperationExecutor.java:71)
	at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.runWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:45)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:71)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction.execute(DefaultCollectionCallbackActionDecorator.java:92)
	at org.gradle.api.internal.collections.CollectionFilter$1.execute(CollectionFilter.java:59)
	at org.gradle.api.internal.DefaultDomainObjectCollection.all(DefaultDomainObjectCollection.java:163)
	at org.gradle.api.internal.plugins.DefaultPluginContainer$2.execute(DefaultPluginContainer.java:163)
	at org.gradle.api.internal.plugins.DefaultPluginContainer$2.execute(DefaultPluginContainer.java:154)
	at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1.execute(DefaultUserCodeApplicationContext.java:100)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction$1.run(DefaultCollectionCallbackActionDecorator.java:95)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:56)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$run$1(DefaultBuildOperationExecutor.java:71)
	at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.runWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:45)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:71)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction.execute(DefaultCollectionCallbackActionDecorator.java:92)
	at org.gradle.api.internal.DefaultDomainObjectCollection.all(DefaultDomainObjectCollection.java:163)
	at org.gradle.api.internal.plugins.DefaultPluginContainer.withId(DefaultPluginContainer.java:167)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin.applyKtfmtToAndroidProject(KtfmtPlugin.kt:82)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin.access$applyKtfmtToAndroidProject(KtfmtPlugin.kt:34)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin$apply$2.execute(KtfmtPlugin.kt:47)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin$apply$2.execute(KtfmtPlugin.kt:34)
	at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1.execute(DefaultUserCodeApplicationContext.java:100)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction$1.run(DefaultCollectionCallbackActionDecorator.java:95)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:56)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$run$1(DefaultBuildOperationExecutor.java:71)
	at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.runWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:45)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:71)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction.execute(DefaultCollectionCallbackActionDecorator.java:92)
	at org.gradle.api.internal.collections.CollectionFilter$1.execute(CollectionFilter.java:59)
	at org.gradle.api.internal.DefaultDomainObjectCollection.all(DefaultDomainObjectCollection.java:163)
	at org.gradle.api.internal.plugins.DefaultPluginContainer$2.execute(DefaultPluginContainer.java:163)
	at org.gradle.api.internal.plugins.DefaultPluginContainer$2.execute(DefaultPluginContainer.java:154)
	at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1.execute(DefaultUserCodeApplicationContext.java:100)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction$1.run(DefaultCollectionCallbackActionDecorator.java:95)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:56)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$run$1(DefaultBuildOperationExecutor.java:71)
	at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.runWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:45)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:71)
	at org.gradle.api.internal.DefaultCollectionCallbackActionDecorator$BuildOperationEmittingAction.execute(DefaultCollectionCallbackActionDecorator.java:92)
	at org.gradle.api.internal.DefaultDomainObjectCollection.all(DefaultDomainObjectCollection.java:163)
	at org.gradle.api.internal.plugins.DefaultPluginContainer.withId(DefaultPluginContainer.java:167)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin.apply(KtfmtPlugin.kt:47)
	at com.ncorti.ktfmt.gradle.KtfmtPlugin.apply(KtfmtPlugin.kt:34)
	at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:43)
	at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:51)
	at org.gradle.api.internal.plugins.DefaultPluginManager.addPlugin(DefaultPluginManager.java:177)
	at org.gradle.api.internal.plugins.DefaultPluginManager.access$100(DefaultPluginManager.java:51)
	at org.gradle.api.internal.plugins.DefaultPluginManager$AddPluginBuildOperation.run(DefaultPluginManager.java:272)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:56)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$run$1(DefaultBuildOperationExecutor.java:71)
	at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.runWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:45)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:71)
	at org.gradle.api.internal.plugins.DefaultPluginManager.lambda$doApply$0(DefaultPluginManager.java:157)
	at org.gradle.configuration.internal.DefaultUserCodeApplicationContext.apply(DefaultUserCodeApplicationContext.java:43)
	at org.gradle.api.internal.plugins.DefaultPluginManager.doApply(DefaultPluginManager.java:156)
	at org.gradle.api.internal.plugins.DefaultPluginManager.apply(DefaultPluginManager.java:127)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.lambda$applyPlugins$0(DefaultPluginRequestApplicator.java:127)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.applyPlugin(DefaultPluginRequestApplicator.java:176)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.lambda$applyPlugins$1(DefaultPluginRequestApplicator.java:125)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.applyPlugins(DefaultPluginRequestApplicator.java:125)
	at org.gradle.plugin.use.internal.DefaultPluginRequestApplicator.applyPlugins(DefaultPluginRequestApplicator.java:121)
	at org.gradle.kotlin.dsl.provider.PluginRequestsHandler.handle(PluginRequestsHandler.kt:48)
...

Javier

12/24/2020, 11:13 PM

is it working for you with agp 4.0.1?

gammax

12/24/2020, 11:14 PM

Oh well 😞

Javier

12/24/2020, 11:14 PM

I really hate AGP 😭

gammax

12/24/2020, 11:14 PM

So I’m on AGP 4.1 while using Android Studio, but I develop the plugin with IJ without AGP.

gammax

12/24/2020, 11:15 PM

Like I’ve tested this plugin on a couple of Android projects with AGP 4.1 and it works fine

Javier

12/24/2020, 11:16 PM

I am going to move to AS then, I can confirm this problem exists with spotless in AS, but in IntelliJ is not happening, I was trying to check if it is being the same problem here

gammax

12/24/2020, 11:28 PM

This is how it behaves on my end:

ktfmtFormat.mov

Javier

12/24/2020, 11:30 PM

if I close AS and I reopen it, it works, I had a similar problem with gradlew test where I have to restart the ide to get it working so I thing this problem is not related to the plugin itself

Javier

12/24/2020, 11:36 PM

I left this here so if someone read this sometime, enabling second and third solve the problem

22 Views

Open in Slack

Previous Next