Today: Started with extension functions support bu...
# python-contributorss
SerVB
09/03/2021, 5:47 PMToday: Started with extension functions support but bumped into regressions in enums. Dug into enums and found out that my PR with object instances wasn't enough. So:
• Added support of more static fields to PR with object instances, +17 more box tests pass.
• Started with support of superclasses that are required for enums:
◦ Resolved the forward declaration stuff.
◦ Did some topology sorting for superclasses in a class declaration to prevent the "Cannot create a consistent method resolution order (MRO)" runtime error
◦ Didn't finish yet so PR will be later.
• Extension functions seem to be ready but they are shelved too for now.
Also, had a call with @ dmitriy.novozhilov (sorry for pinging) – he suggested to switch to new testing infrastructure that utilizes JUnit 5 and makes parallel tests launching more effective. Some work will be required but I think it's needed for us and also the old testing infrastructure is going to be deprecated.
Next time:
• Finish what I've started today.
• Another idea is to make a script to count box test fail reasons, will do and add CI for it.
• Start with switching to the new testing thing.
🦜 1
SerVB
09/03/2021, 5:48 PMJFYI: Unfinished superclasses give me +75 box tests passing
p
Piotr Krzemiński
09/03/2021, 5:57 PMCool stuff!
🦜 1
Piotr Krzemiński
09/04/2021, 8:43 AMJust wondering if it's also time to sync our fork with the parent repo
s
SerVB
09/04/2021, 9:53 AMYou mean with 1.5.30, right? Well, do you think it's needed to sync with every release? I remember the last sync, it wasn't much fun, but maybe it's exactly because we skipped many releases...
If you want, you can do it. Or I can take a look in about two weeks...
p
Piotr Krzemiński
09/04/2021, 10:23 AMI didn't mean merging with every release, just wondering if we should merge only of something stops working on our side (like last time), or proactively, more frequently, to avoid big-bang merging. I guess we can agree to merge every major release (1.5, 1.6) as a trade-off, now we should focus on delivering some MVP 😄
Piotr Krzemiński
09/04/2021, 10:24 AMMakes sense to you?
s
SerVB
09/04/2021, 11:01 AMYeah, I like the idea to postpone the next merge to 1.6. Indeed will give us time to work on our stuff.
Maybe we should merge like every second big release, like 1.5.2, then 1.6.0, then 1.6.2 and so on. It will be about 4 times a year that shouldn't load us much
👍 1
3 Views