https://kotlinlang.org logo
l

louiscad

03/12/2022, 8:02 PM
Hello, can we expect the https://github.com/androidx/androidx repo to accept AndroidX Wear contributions soonish?
3
j

John Nichol

03/13/2022, 9:14 AM
Happy to look into enabling this - I would be happy in principle to take contributions. Was there something specific you were looking to contribute?
l

louiscad

03/13/2022, 11:19 AM
Yep, I found a little pointless
/** @hide */
on an
internal
setter that I wanted to remove.
j

John Nichol

03/13/2022, 1:05 PM
which one - let me take a look
l

louiscad

03/13/2022, 1:16 PM
I think doing cmd/ctrl + shift + F and searching for
/** @hide */
will reveal it, I moved on as I couldn't easily contribute, but I think you'll easily find it back by filtering into androidx.wear.watchface directories.
Hello, is there any progress on that? 🙏🏼 Now, I'd like to send fixes on Wear Compose (for `Card`'s
onClick
internals that has the touch feedback/ripple not fill the entire element if the text doesn't have the
fillMaxWidth()
Modifier (I don't like to have to specify it, it's more boilerplate).
y

yschimke

03/28/2022, 8:17 AM
Just found the code here https://github.com/androidx/androidx/tree/androidx-main/wear/compose - are you looking for confirmation that a PR will be picked up?
l

louiscad

03/28/2022, 9:07 AM
Yup, because it's not in the list in the README:
👍🏻 1
j

John Nichol

03/29/2022, 7:30 AM
Louis was asking about contribution to Watchface previously - I took a quick look but didn't immediately find how to get the libraries allow listed. Also it's quite involved to take external contributions especially API impacting ones. I will take an action to look at this again, but in the mean time feel free to raise bugs with suggested improvements.
🙏🏼 1
l

louiscad

03/29/2022, 8:04 AM
For the documentation fixes, is it really "quite involved"?
j

John Nichol

03/30/2022, 7:11 AM
Even for documentation it is not straightforward as we have to do extra steps behind the scenes to shepherd changes through - but nevertheless I have checked and apparently external contributions are actually enabled by default which is why I couldn't find steps to turn it on - so feel free to make contributions - I have asked for the documentation that you cited to be corrected so that it is clear that you can contribute
🦜 1
l

louiscad

03/31/2022, 12:02 PM
Great! That applies to all androidx.wear libraries, including watchface, and compose, right?
j

John Nichol

04/05/2022, 8:35 AM
That is what I understand
y

yschimke

05/14/2022, 12:56 PM
I tried this to investigate a preview fix. Needed to make some changes to the build.gradle files and settings.gradle. But working to compile the wear-compose code. This was just an experiment and suggests there is some work needed to cleanly support external PRs. https://github.com/yschimke/androidx/commit/fb4b11b96da1c3b37c9828077a4bf696ebdad194
@louiscad is there any PR you were thinking of to test this process?
l

louiscad

05/15/2022, 8:42 PM
I'll have to search back, or I'll make a minor doc edit to try it out.
3 Views