Is something still missing in my PR

Question

Is something still missing in my PR <https github com krzema12 github actions kotlin dsl pull 62>

Piotr Krzemiński · Answer

if you tested the wrappers work fine with these versions then it s fine slightly smiling face I think I asked about it somewhere in the comments

Piotr Krzemiński · Answer

at some moment I asked you to switch from e g `v2 1 0` to `v2` but then I thought it may not actually work my bad I just ask to double check it in runtime

Piotr Krzemiński · Answer

I m working on generating the wrappers then such problems will disappear <https github com krzema12 github actions kotlin dsl issues 71>

jmfayard · Answer

I will check that the wrappers work

jmfayard · Answer

Yes it does work it generates this Yaml file <https github com LouisCAD kotlin libraries playground pull 114 files diff d63d8c6a21c718b5f0e11ecd0b5d7cef6aae4c9753a86b16c94e45a49842c6bf>

Piotr Krzemiński · Answer

Do you have an example run of RefreshVersions PR workflow

Piotr Krzemiński · Answer

Yaml itself doesn t mean it will work

Piotr Krzemiński · Answer

I see only runOnGitHub check

jmfayard · Answer

It outputs the same yaml that did work at and generated the PR here

Piotr Krzemiński · Answer

Ok thanks Approving

Piotr Krzemiński · Answer

Thank you

Piotr Krzemiński · Answer

unfortunately it doesn t work <https github com krzema12 test repo runs 5070645674 check suite focus=true> it says Error Unable to resolve action `peterjgrainger action create branch v2` unable to find version `v2`

Piotr Krzemiński · Answer

I think that the new wrappers don t output exactly the same YAML as the versions are different Other changes we see here are cosmetics

Piotr Krzemiński · Answer

tracked in <https github com krzema12 github actions kotlin dsl issues 72>

jmfayard · Answer

wouldn t it make sense to add in the constructor of `Action` a call to `curl H Accept application vnd github v3+json <https api github com repos peterjgrainger action create branch releases>` that would throw an error if the tag doesn t exist outputs a warning if a newer version of the Action is available + adding an API to override the version something like `Action withVersion 2 1 6 `

Piotr Krzemiński · Answer

I d like to handle version checking primarily in build time of the library but what you say can be an alternative opt in approach especially with overriding the version I thought about it Could you create a feature request

jmfayard · Answer

Checking new versions is not so important I did a ticket about the rest

jmfayard · Answer