o

    Ola Adolfsson

    1 year ago
    Hi regarding https://youtrack.jetbrains.com/issue/KT-43237, are there more people affected? In our case we need to do a somewhat orthodox workaround renaming the imports to the affects js libs. “KJS:
    -jsLegacy
    Naming Convention is incompatible with NPM
    Libraries such as 
    kotlinx.serialization
     are exporting artifacts with a 
    -jsLegacy
     suffix when using the legacy compiler with Kotlin 1.4. NPM however, doesn’t allow capital letters in package names.”
    Patrick Doering

    Patrick Doering

    1 year ago
    That would be great if that could be fixed.
    o

    Ola Adolfsson

    1 year ago
    @Artyom Degtyarev [JB] what do you think? 🙂
    Artyom Degtyarev [JB]

    Artyom Degtyarev [JB]

    1 year ago
    Can’t tell anything specific right now. Got to ask my teammate tomorrow.
    Ilya Goncharov [JB]

    Ilya Goncharov [JB]

    1 year ago
    Hi, thanks, It is necessary to fix, but unfortunately I am not sure, that it will be fixed in next release (1.4.30) But if you affected by your own generated js file, you can use
    moduleName
    For example:
    kotlin {
      js {
        moduleName = project.name
      }
    }
    But unfortunately it is not so useful for external dependencies
    o

    Ola Adolfsson

    1 year ago
    Is there anything we can do? if it’s an easy fix then we can perhaps create a PR? 🙂
    Ilya Goncharov [JB]

    Ilya Goncharov [JB]

    1 year ago
    It is something like
    decamelize
    I have already made commit Now it is testing
    o

    Ola Adolfsson

    1 year ago
    So we can perhaps get it in 1.4.30? 🙂 . Ship it. 🚢
    I can test it tomorrow if you provide the artefact or instructions how to compile it 🙂 .
    Ilya Goncharov [JB]

    Ilya Goncharov [JB]

    1 year ago
    So we can perhaps get it in 1.4.30?
    I am afraid, that not, release cycle of 1.4.30 already is in progress (1.4.30-M1 already released 🙂 ) Another one problem, that I want to investigate effect of this change in term of compatibility (in fact it can be problem, because file name is important in js ecosystem)
    I can test it tomorrow if you provide the artefact or instructions how to compile it 
    If I understand you correctly, it is important for you to get correct names of kotlin libraries (kotlinx.serialization e.g.), and it can will be ok only after republishing of such libraries (and it will be in their corresponding release cycles) If you only need to change your own names, you can use
    moduleName
    in your projects
    o

    Ola Adolfsson

    1 year ago
    If I understand you correctly, it is important for you to get correct names of kotlin libraries (kotlinx.serialization e.g.), and it can will be ok only after republishing of such libraries (and it will be in their corresponding release cycles)
    yeah thats correct. 🙂 .
    If you only need to change your own names, you can use 
    moduleName
     in your projects
    We’re aware of that setting 🙂 .
    b

    bughunter

    1 year ago
    Yeah ok but when you use ktor you will have the same Problems.
    o

    Ola Adolfsson

    1 year ago
    @bughunter how do you mean?
    Patrick Doering

    Patrick Doering

    1 year ago
    @Ilya Goncharov [JB] in which version will be the decamelize feature?
    Ilya Goncharov [JB]

    Ilya Goncharov [JB]

    1 year ago
    It should be in 1.5.0 releases (1.5.0-M1, 1.5.0-M2 and so on)
    Patrick Doering

    Patrick Doering

    1 year ago
    When is the release planned?
    Ilya Goncharov [JB]

    Ilya Goncharov [JB]

    1 year ago
    M1 (milestone-1) is already released, and bug is fixed in it M2 should be in near future, but we don’t provide concrete estimates