Uh… I think I got confused with something while juggling many different kind of changes. Replacing `...

# multiplatform

[saket]

Uh… I think I got confused with something while juggling many different kind of changes. Replacing iosX64() with fromPreset(presets.iosX64) is fine, but the actual error is coming from these lines:

framework {
  // Disable bitcode embedding for the simulator build.
  if (!buildForDevice) {
    embedBitcode("disable")
  }
}

[ilya.matveev]

Thank you, we will look at this problem. Do I understand correctly that a repro for this problem is just this PR: https://github.com/saket/press/pull/22?

[saket]

Yes!

[kpgalligan]

I kind of whittled down the code and got past the header gen issue. I thought I had it spotted, but reverting to isolate brought it all back

[saket]

I realized that assertk is also a bottleneck because it's on an older version of kotlin. Once I get this setup working, I'm never updating the kotlin version until k/n becomes ABI stable.

[kpgalligan]

It’s not that bad. Just need to use updated libraries 🙂

[kpgalligan]

OK. I have some news. Look here: https://github.com/kpgalligan/press/tree/kpg/dec12/no-crash

[kpgalligan]

I’ve cloned and updated the old test libraries. See deps.

[kpgalligan]

They’re snapshots but I can publish them for real if interested

[kpgalligan]

I used my special compiler sniffer tech to isolate the problem with the header. Or at least “a” problem. If you replace the object with TODO(), this will compile and build the framework: https://github.com/kpgalligan/press/blob/kpg/dec12/no-crash/shared/src/commonMain/kotlin/me/saket/press/shared/rx/TakeWhile.kt#L21

[kpgalligan]

subscribe(
        object : ObservableObserver<T>, CompletableCallbacks by emitter {
          override fun onSubscribe(disposable: Disposable) {
            disposableWrapper.set(disposable)
          }

          override fun onNext(value: T) {
            emitter.tryCatch(block = { predicate(value) }) {
              when {
                it -> emitter.onNext(value)
                else -> emitter.onComplete()
              }
            }
          }
        }
    )

[kpgalligan]

Instead of that, this

subscribe(
            TODO()
        /*object : ObservableObserver<T>, CompletableCallbacks by emitter {
          override fun onSubscribe(disposable: Disposable) {
            disposableWrapper.set(disposable)
          }

          override fun onNext(value: T) {
            emitter.tryCatch(block = { predicate(value) }) {
              when {
                it -> emitter.onNext(value)
                else -> emitter.onComplete()
              }
            }
          }
        }*/
    )

[kpgalligan]

That compiles and builds framework, so whatever is failing is in there. Either just the standalone object, or by emitter, but something is crashing the compiler.

[kpgalligan]

The “special compiler sniffer tech” is just smart guesses and cutting out lots of code till it works, then adding it back.

[saket]

Omg kevin how did you manage to do this. There were so many files. I'll try this as soon as I get back home today.

[kpgalligan]

https://youtu.be/5Nvxv2R01po?t=62▾

[kpgalligan]

Some guesses. Some “binary search” as in cut out a bunch of code, and see if it still crashes.