Channels
#multiplatform
Title
p
patjackson52
11/14/2018, 10:12 PMAnyone interested in showing Timber some MPP love? I’ve created a WIP PR to refactor to the new MPP plugin. Still needs a lot of work overall to get it into proper shape. Would be nice to have easy logging with the familiar API on iOS & Android. Comments are welcome… https://github.com/JakeWharton/timber/pull/341
k
kpgalligan
11/14/2018, 10:16 PMIve done this mostly. Not the mpp part (still platform plugin), but the native changes https://github.com/touchlab/timber/tree/native
See droidcon app for live use https://github.com/touchlab/DroidconKotlin
l
louiscad
11/14/2018, 10:17 PMNew MPP doesn't allow Android libraries publishing yet (should be fixed in 1.3.20 though)
k
kpgalligan
11/14/2018, 10:18 PMSo, just use my version then. Works with android too :)
👍 1
p
patjackson52
11/14/2018, 10:22 PMnice! still would be great to have a published artifact from the official repo. I believe the work around is to have a separate module for the android artifact.
k
kpgalligan
11/14/2018, 10:26 PMAnything I’ve been publishing that has an Android artifact and isn’t mpp I’ve just left as platform plugin for now. There’s not a lot of value in converting and adding a workaround. Waiting for 1.3.20 seems like less work
What’s the “official repo”? Jecenter or maven central?
I’ve been publishing to a bintray repo due to pace of changes in platform. Assuming that will be much more stable soonish.
p
patjackson52
11/14/2018, 10:28 PMmeant the timber github repo. Seems like Jake wants to make it MPP. There is an issue for it
k
kpgalligan
11/14/2018, 10:29 PMAh. Ok
p
patjackson52
11/14/2018, 10:29 PMand a published artifact in the usual places (jcenter, maven central)
k
kpgalligan
11/14/2018, 10:30 PMThe other dimension is 4.10 gradle and metadata. Just FYI
And native
a
addamsson
11/14/2018, 10:31 PM@kpgalligan do you know how to realease to maven cetnral with the new
kotlin-multiplatformI haven't managed yet
k
kpgalligan
11/14/2018, 10:32 PMI’ll be republishing most of the libraries I’m using in Droidcon over the next few days for 4.10. In advance of Droidcon sf
@addamsson no on maven central. I suspect sqldelight will go there
a
addamsson
11/14/2018, 10:33 PMi'm intrigued
k
kpgalligan
11/14/2018, 10:34 PMI hacked JetBrains version of bintray plugin to push to bintray, which could in theory end up in jcenter, but gradle and publishing is not my favorite chore, so I tend to stop at “good enough “
a
addamsson
11/14/2018, 10:35 PMyea I use jitpack 😄
k
kpgalligan
11/14/2018, 10:36 PMAnything coming from square and/or jw tends to avoid bintray afaik. I haven’t explored why too much. Kind of waiting for somebody else to figure that out
a
addamsson
11/14/2018, 10:37 PMmy guess is that it is equally as hard to push to maven central
and when they are equally hard i'd rather use MC instead of bintray
k
kpgalligan
11/14/2018, 10:39 PMOh, I don’t think they are. Bintray is pretty easy, at least before 4.10, which took a little hacking. I’ll have to figure out how mc works to contribute to square libs, though. Any pr involves my hacks to bintray, which makes a mess. For my repos, though, not a big issue
Apparently I didn’t push changes, but latest goes to bintray with 4.10.2 https://github.com/touchlab/Stately
In car on a phone, so it’ll be a bit before I get to it
a
addamsson
11/14/2018, 10:41 PMfor MC you need:
- signing
- javadoc
- sources
- ossrh user + approved domain
that's pretty much it
and straightforward to set up
k
kpgalligan
11/14/2018, 10:44 PMYeah, bintray needs a user org and user key, plus creating a project on mc requires some sort of application review. Probably a good thing, but easier to be up and pushing to bintray. Not saying that’s a good thing. Just simpler
I don’t know how that handles the metadata deployment. That definitely needs to work for native publishing
l
louiscad
11/14/2018, 10:47 PMSome users of Square libraries use exclusively mavenCentral, so that's partly why they don't use bintray (although bintray mirrors mavenCentral)
k
kpgalligan
11/14/2018, 10:48 PMAll for it. Just waiting to see a functional sample :)
l
louiscad
11/14/2018, 10:49 PM@kpgalligan Publishing on jcenter from bintray is not hard. You basically click a button, fill a form (ro just leave it empty), then wait for approval notification, and that's it, all the versions will be synced to jcenter
a
addamsson
11/14/2018, 10:50 PMcan you link to a square library which deploys to maven central and uses the
kotlin-multiplaformi'm not familiar with that lib
l
louiscad
11/14/2018, 10:50 PMIt's always better to push on jcenter, because you can't remove something from it just like you could on a private bintray repo, so it's more reliable to depend only on jcenter and mavenCentral published artifacts
k
kpgalligan
11/14/2018, 10:51 PMSort of
I’m not sure they’re ready for mpp publishing (or I didn’t include everything). Wasn’t a huge priority to sort out till after Droidcon
I agree that publishing to a non-changing endpoint is good. However, until recently, all native versions weren’t backward compatible, and gradle metadata also wasn’t (isn’t) backward compatible, so you wind up with a lot of versions, as you need to republish when anything changes. That obviously needs to stabilize as we go forward, but over the last few months, not much was stable
l
louiscad
11/14/2018, 10:57 PM@kpgalligan You're just missing the sources. Here's what I use for Android only libraries: https://github.com/LouisCAD/Splitties/blob/master/publish.gradle#L39
k
kpgalligan
11/14/2018, 11:02 PM@louiscad I have sources for js, jvm, and native artifacts. Still got bounced. Hence the “sort it out later” thinking. Didn’t feel like a conversation with bintray support, especially since I’m not a paying customer. The mpp publishes a lot of folders. That includes common folder and metadata folder, which I guess we could try to copy sources into, but you know. Not my highest priority
Today, I mean. Obviously eventually, but was also thinking a re-evaluation on jcenter va mavencentral
j
jw
11/15/2018, 3:50 AMJCenter are untrustworthy, don't use them. We already have multiplatform publishing set up on SQL Delight for Maven Central. It's not hard.
l
louiscad
11/15/2018, 6:37 AM@jw What makes you say they're untrustworthy? I want to know the rationale behind this statement.
a
addamsson
11/15/2018, 10:27 AM@jw how did you do that? Are you using the new
kotlin-multiplatformI just checked, there is no reference to
kotlin-muiltiplatformr
russhwolf
11/15/2018, 12:04 PMThey use the
org.jetbrains.kotlin.multiplatforma
addamsson
11/15/2018, 4:48 PMoh I see
do you plan to write a guide on how to publish multiplatform projects to maven central?
r
russhwolf
11/15/2018, 5:07 PMWho are you asking? I don't think anyone has definitive best-practices outside of JetBrains at the moment.
a
addamsson
11/15/2018, 8:25 PMI was asking @jw
j
jw
11/15/2018, 8:28 PMa
addamsson
11/15/2018, 10:12 PMGreat thanks for that!!!
4 Views