A modern programming language that makes developers happier.

kotlinlang

Hi guys, i currently attempt to work on a multiplatform HTTP Client for Kotlin. JS and Java works for the moment but perhaps not in the most optimized way. Any people interessed to help me on this ?

We will publish one as part of <#C0A974TJ9|ktor> very soon 

Oh interesting. If you want help from me :)

<https://github.com/e5l/http-client-common>

One thing I've found to be good general advice if you're mapping an expect/actual to an existing platform class, is to write the expects are extensions functions. This makes it possible to create similar functionality without having to create a wrapper around there class.

```expect class HttpClient
expect fun HttpClient.getUrlBuilder(baseUrl: String): UrlBuilder
expect fun HttpClient.getHttpRequest(methodType: String, url: Url): HttpRequest
expect fun HttpClient.send(body: String?, httpRequest: HttpRequest, complete: HttpRequestCallback)```

```actual class HttpClient
actual fun HttpClient.getUrlBuilder(baseUrl: String): UrlBuilder {
    return URL(baseUrl)
}
actual fun HttpClient.getHttpRequest(methodType: String, url: Url): HttpRequest {
    val httpRequest = XMLHttpRequest()
    httpRequest.open(methodType,url)
    return httpRequest
}
actual fun HttpClient.send(body: String?, httpRequest: HttpRequest, complete: HttpRequestCallback) {
    httpRequest.onreadystatechange = {
        if (httpRequest.readyState == HTTP_FINISHED_CODE) {
            complete(httpRequest.status.toInt(),httpRequest.responseText)
        }
    }
    httpRequest.send(body)
}```

I wouldn't suggest anyone using it, but it shows what I mean well enough

<@U0BN9C0HM> and what about HttpRequest class - expect with actual typealias?

And I don't see much difference with classes anyway, e.g. <https://github.com/e5l/http-client-common/blob/master/jvm/src/main/kotlin/io/ktor/common/client/JvmHttpClient.kt>

Good point, this is actually really to allow for OkHttp

on the JS platform its not necessary, but it is to create a common API

<@U0BN9C0HM> ha, I've wrapped okhttp, too

Ya which is the point, its not suppose to be a wrapper just a common API over pre-existing libraries