czyzby
02/10/2018, 9:28 PManton.bannykh
02/12/2018, 9:30 AMunpackDependenciesTestKotlinJs
. It was a task generated by the kotlin-dce-js plugin. We've removed it in 1.2.20
(Sorry =( )czyzby
02/12/2018, 6:51 PMmeta.js
files as well? My tests fail without that.Kotlin.defineModule('client', _);
from all JS libraries and I'm unable to run the tests.task customDce(type: org.jetbrains.kotlin.gradle.tasks.KotlinJsDce, dependsOn: compileKotlin2Js) {
classpath = configurations.compile
source compileKotlin2Js.outputFile
dceOptions {
devMode = true
outputDirectory = "$build/node_modules/"
}
destinationDir = "$build/node_modules/"
}
This throws an exception, because destinationDir
is unknown. If I remove the destinationDir
line, it complains about missing destinationDir
property. ><populateNodeModules
for now.anton.bannykh
02/13/2018, 11:25 AMtask customDce(dependsOn: [compileKotlin2Js, runDceKotlinJs]) {
runDceKotlinJs.dceOptions {
devMode = true
outputDirectory = "$build/node_modules/"
}
}
czyzby
02/13/2018, 4:27 PMrunDceKotlinJs.dceOptions
in `doLast`/`doFirst`, I think. And this prevents from using the original runDceKotlinJs
without dev mode in the same pipeline as customDce
, which is something I wanted to avoid.populateNodeModules
with DCE, but since even in devMode
it strips module registration, I simply cannot.anton.bannykh
02/13/2018, 4:46 PMrunDceKotlinJs
without dev mode in the same pipeline as `customDce`"? Do you want to use them both during the same build?Kotlin.defineModule
by any chance? In that case please note that's a marker function, it doesn't do anything: https://github.com/JetBrains/kotlin/blob/7bee2ceac7a63ea1bbecc47de1c40aa31a95ea72/js/js.libraries/src/js/markerFunctions.js#L21czyzby
02/13/2018, 7:51 PMmodule not defined
errors all over the tests.populateNodeModules
manually into the DCE output folder (without running DCE, of course) and rerun the tests, everything was working as expected.'build/node_modules/*.js',
in Karma config to two output folders from the DCE tasks and run both in dev mode.anton.bannykh
02/14/2018, 11:40 AM