Is there a more elegant way to do something like this ```fun kotlinlang #codingconventions

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

e

Ellen Spertus

05/14/2022, 9:04 PM

Is there a more elegant way to do something like this:

fun getSomething(): SomeType {
   val result = computeSomething()
   doSomethingElse()
   return result
}

:yes: 2

s

Sam

05/14/2022, 9:06 PM

return computeSomething().also { doSomethingElse() }

🥇 2

s

Szymon Jeziorski

05/15/2022, 10:10 AM

or even convert it to function assignment altogether (you could also skip return type if it's clear):

fun getSomething() = computeSomething().also { doSomethingElse() }

🥇 1

j

Jordan Petersen

05/16/2022, 4:07 PM

In my opinion, these are all valid. However,

doSomethingElse()

trigged in a function called

getSomething()

could be a confusing side effect. I would say that should be called separately so that the only purpose of

getSomething()

is to get something 😒imple_smile:.

☝️ 1

e

Ellen Spertus

05/20/2022, 8:59 PM

@Jordan Petersen Good point.

👍 1

4 Views

#codingconventions Join Slack