Which one did you prefer nested data class or higher order d kotlinlang #codingconventions

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

m

miqbaldc

09/09/2021, 5:28 AM

Which one did you prefer: nested data class or higher-order data class? Code in 🧵

2️⃣ 5

1️⃣ 1

1️⃣ nested data class

data class TimeBasedHistoryDetail(
    val id: String,
    val attendanceValidation: AttendanceValidation?,
) {
    data class AttendanceValidation(
        val attendanceValidationQuestionSchema: AttendanceValidationQuestionSchema?,
    ) {
        data class AttendanceValidationQuestionSchema(
            val type: String?,
            val title: String?,
            val description: String?,
        )
    }
}

2️⃣ higher-order (I’m not sure what’s this called, cmiiw)

data class TimeBasedHistoryDetail(
    val id: String,
    val attendanceValidation: AttendanceValidation?,
)

data class AttendanceValidation(
    val attendanceValidationQuestionSchema: AttendanceValidationQuestionSchema?,
)

data class AttendanceValidationQuestionSchema(
    val type: String?,
    val title: String?,
    val description: String?,
)

m

Matteo Mirk

09/09/2021, 7:49 AM

“higher-order” is the wrong term, it means something completely different. The correct definition is “top level”

:thank-you: 1

:today-i-learned: 1

t

Tobias Berger

09/09/2021, 3:34 PM

I think both options are valid. I find 2️⃣ easier to read in the code, but 1️⃣ contains more information about the structure. However, when going with 1️⃣ , I would shorten

AttendanceValidationQuestionSchema

to just

QuestionSchema

to avoid redundant information in the class name

:thank-you: 2

➕ 7

:today-i-learned: 1

4 Views

#codingconventions Join Slack