which one do you prefer/recommend or maybe another...

# codingconventions

[miqbaldc]

which one do you prefer/recommend or maybe another alternative options to suggest?

1️⃣

private fun AccountInfo?.isNotEmpty() = this != null && 
    id.isNullOrBlank().not() && 
    status.isNullOrBlank().not() &&
    something.isNullOrBlank().not()

2️⃣

private fun AccountInfo?.isNotEmpty() = this != null 
    && id.isNullOrBlank().not() 
    && status.isNullOrBlank().not()
    && something.isNullOrBlank().not()

3️⃣ (linter will complain when exceeded the max length)

private fun AccountInfo?.isNotEmpty() = this != null && id.isNullOrBlank().not() && status.isNullOrBlank().not() && something.isNullOrBlank().not()

[ephemient]

1️⃣ but I would always use ! instead of .not()

[ephemient]

https://developer.android.com/kotlin/style-guide#where_to_break "When a line is broken at an operator or infix function name, the break comes after the operator or infix function name."

[ephemient]

IMO good style regardless of whether you work on Android. because of Kotlin's optional semicolon, binary operators at the start of a line will be parsed as unary operators instead, and it will simply fail for inline function names

[miqbaldc]

turned out after using ktlint, no. 1️⃣ will make ktlint complaint 😞 and suggesting us to use 2️⃣

[ephemient]

?? ktlint should be suggesting 1️⃣ and warning about 2️⃣

[ephemient]

running it here with 2️⃣, it says

Line must not begin with "&&"

[miqbaldc]

oops, looks like our ktlint rules is messed up with default intellij idea rules (maybe the obsolete one)