First or second? ```startActivityForResult( C...

# codingconventions

[therealbluepandabear]

First or second?

startActivityForResult(
    CheatActivity.newIntent(this@MainActivity, quizViewModel.currentQuestionAnswer),
    REQUEST_CODE_CHEAT,
    ActivityOptions.makeCustomAnimation(
        this,
        R.anim.fragment_fade_enter,
        R.anim.fragment_fade_exit
    ).toBundle()
)

val intent = CheatActivity.newIntent(this@MainActivity, quizViewModel.currentQuestionAnswer)
val animation = ActivityOptions.makeCustomAnimation(this, R.anim.fragment_fade_enter, R.anim.fragment_fade_exit).toBundle()
startActivityForResult(intent, REQUEST_CODE_CHEAT, animation)

[ephemient]

neither, use the new activity result apis instead

[therealbluepandabear]

@ephemient how do I do that

[ephemient]

https://lmgtfy.app/?q=android+activity+result+api - also, not Kotlin.

[therealbluepandabear]

@ephemient this is Kotlin

[ephemient]

your code is, but the API is not, and that's what you should have looked up yourself after my first reply.

[ephemient]

and enough with the unwarranted @therealbluepandabear @therealbluepandabear @therealbluepandabear @therealbluepandabear @therealbluepandabear pings already

[therealbluepandabear]

most Kotlin devs use Java APIs in their projects.

[therealbluepandabear]

also how am I supposed to know whether it's Java API or Kotlin API?

[ephemient]

yes, but don't come here asking about the Java parts. do your own research.

[therealbluepandabear]

reminds me of something else lol

[therealbluepandabear]

Nevermind.

[Matteo Mirk]

kotlin-specific part: maybe I’ll go with the first form, using named arguments for clarity:

startActivityForResult(
    intent = CheatActivity.newIntent(this@MainActivity, quizViewModel.currentQuestionAnswer),
    code = REQUEST_CODE_CHEAT,
    bundle = ActivityOptions.makeCustomAnimation(
        this,
        R.anim.fragment_fade_enter,
        R.anim.fragment_fade_exit
    ).toBundle()
)

As for the Android-specific part, I know next to nothing so forgive me in advance (for example arg names are surely wrong).

[ephemient]

unfortunately named arguments don't work with Java APIs

[Matteo Mirk]

oh rats! I forgot that 😞