Hello, I remember something about avoiding the usa...

# codingconventions

[orafaaraujo]

Hello,
I remember something about avoiding the usage when when you can go with a simple if
But I can’t find it now… Does anyone knows where is it?

[orafaaraujo]

e.g.:
do

if (bla) { 
...
} else  {
...
}

Instead of

when(bla) {
true -> ...
false -> ...
}

[Marc Knaup]

When used as an expression I often find the latter easier to read.

[Marc Knaup]

https://kotlinlang.org/docs/reference/coding-conventions.html

[Marc Knaup]

[orafaaraujo]

I think I found it
https://kotlinlang.org/docs/reference/coding-conventions.html#if-versus-when

[orafaaraujo]

Thank you, @Marc Knaup
I think when really charm as well, I was just wondering in that specific case

[Marc Knaup]

I find it way more balanced 🙂

[orafaaraujo]

this really makes me think which one would fits better…

[orafaaraujo]

In your case, following the link, I would go with if (revealsPassword) text else password and using `import InputType.text`/`.password`

[Marc Knaup]

That’s definitely something I don’t do.
I don’t want to have all these symbols flying around without qualification.
Also, there’s a local variable called password.

[orafaaraujo]

Got it
this example of text and password doesn’t really help haha

[alex]

I find when easier to read in assigning expressions, especially if condition/action is not short.
Basically, if if cannot be expressed as
val x = if (flag) then y else z, I'd prefer when.

Few weeks ago I found very big project with code linting extremes, such as "do not use if at all, use when instead". Can't remember if this rule was applied for all if constructions or just an assinging expression though.

[Shawn]

how about a compromise that’ll make everyone unhappy?

val result = when {
  foo -> "true"
  else -> "false"
}