Which is the better approach for `name`? ```sealed...

# codingconventions

[daphillips]

Which is the better approach for name?

sealed class Things {
    abstract val name: String

    data class ThingA(val x: Int, val y: String) : Things() {
        override val name = "foo"
    }

    data class ThingB(z: Double) : Things() {
        override val name = "bar"
    }
}

or

sealed class Things(val name: String) {
    data class ThingA(val x: Int, val y: String) : Things("foo")

    data class ThingB(z: Double) : Things("bar")
}

[Mike]

I'd go with 2 for a number of reasons. The second tells me at a glance that all Things have a name, and it's also less code to read.

[tddmonkey]

I prefer 2 also. We’ve done 1) and I’ve found it quite difficult to follow

[daphillips]

Makes sense. Thanks for the input!