<https://ktor.io/quickstart/code-style.html#with-s...
# codingconventionse
enleur
11/19/2018, 6:15 PMhttps://ktor.io/quickstart/code-style.html#with-star-imports who uses this in projects?
➕ 1
e
elizarov
11/19/2018, 9:20 PMI do! 🧌
elizarov
11/19/2018, 9:22 PMThe reason is for DSLs. It leads to a simpler (more fluent) coding in DSL-heavy apps. The heuristic here is when you use one thing from a package, you’ll like to use more (give that things are properly split into packages), which is especially true for libraries that follow Kotlin-style design and prefer extensions over members.
elizarov
11/19/2018, 9:23 PMAs a bonus, you get fewer conflicts during merge (though IDEA’s “magic wand” in 3-way merge window is super-helpful)
e
enleur
11/19/2018, 9:24 PMI see it’s used on all kotlin libs, but why is it not included in official code style?
e
elizarov
11/19/2018, 9:25 PMIs anything related to imports is included into official code style?
e
enleur
11/19/2018, 9:26 PMthat’s why i’m asking 🙂
e
elizarov
11/19/2018, 9:28 PMI am not sure it is of any importance for inclusion into an official style guide. Moreover, it might be really a project-dependent choice. For example, for beginners it might be easier to read code when imports are explicit and in some case they help during code review for those people who do it often in GitHub (I, for one, almost always load PRs into IDEA for review. I’m a heavy Ctrl-clicker)
👍 1
g
gildor
11/21/2018, 5:15 AMSupport of Github PRs is coming to Idea 2018.3, really want to use this, it will significantly simplify our workflow, reviewing on GH web is very tedious thing
e
elizarov
11/21/2018, 8:11 AMI use a variant of this alias https://gist.github.com/gnarf/5406589
2 Views