How would you guys recomend to use elvis operator on long expressions with line breaks ```val a = foo computeBar Baz class java fetchFirst return thisComputationFun``` or ```val a = foo computeBar Baz class java fetchFirst return thisComputationFun``` or none at all The IDE has recomended me to do this in place of the classic `if a == null return thisComputationFun`

How would you guys recomend to use elvis operator on long ex kotlinlang #codingconventions

Channels

lincheck

kobweb

kotlin-multiplatform-contest

osgi

brikk

revolver

tricity-kotlin-user-group

cincinnati-user-group

prozis-android-backup

refactoring-to-kotlin

russian-kotlinasfirst

androidgithubprojects

navigation-architecture-component

stayhungrystayfoolish

practical-functional-programming

tensorflow

swagger-gradle-codegen

kotlinultimatechallenge

competitive-programming

skia-wasm-interop-temp

java-to-kotlin-refactoring

event21-community-content

myndocs-oauth2-server

jvm-ir-backend-feedback

Title

gabrielfv

10/11/2017, 7:33 PM

How would you guys recomend to use elvis operator on long expressions with line breaks?

val a = foo.computeBar(Baz::class.java).fetchFirst() ?:
        return@thisComputationFun

val a = foo.computeBar(Baz::class.java).fetchFirst()
        ?: return@thisComputationFun

or none at all? The IDE has recomended me to do this in place of the classic

if (a == null) return@thisComputationFun

diesieben07

10/11/2017, 7:38 PM

My intuition says

val a = foo.computeBar(Baz::class.java)
           .fetchFirst() ?: return@thisComputationFun

gabrielfv

10/11/2017, 7:42 PM

With the return in the same identation?

deviant

10/11/2017, 7:42 PM

val a = foo
    .computeBar(Baz::class.java)
    .fetchFirst()
    ?: return@thisComputationFun

diesieben07

10/11/2017, 8:03 PM

That looks very weird to me, but I guess it could work

gabrielfv

10/11/2017, 8:06 PM

If I had to choose, would be a mix of both:

val a = foo.computeBar(Baz::class.java)
        .fetchFirst() ?:
        return@thisComputationFun

diesieben07

10/11/2017, 8:12 PM

I have to disagree with that, if you're just scanning it's easy to miss and you see "oh this just returns" instead "this returns on a condition"

gabrielfv

10/11/2017, 8:24 PM

Well, indeed

but on a similar identation to the

val a

it looks like its just returns as well. On a similar level of a

.method()

it draws some more attention.

Another alternative identation might work as well, but I really can't figure a better one

bdawg.io

10/12/2017, 6:15 PM

I hate deep nesting (it’s high churn in your code just waiting to happen). I also dislike mixing the location of signal symbols (

to invoke a method and

?:

to signal an elvis operation). My vote would be

1. val a = foo.computeBar(Baz::class.java).fetchFirst()
2.     ?: return@thisComputationFun

1. val a = foo
2.     .computeBar(Baz::class.java)
3.     .fetchFirst()
4.     ?: return@thisComputationFun

(although I agree with intellij about breaking out this logic from your assignment operator)

2️⃣ 1

#codingconventions Join Slack