```fun get_currency_value(currency: String): Strin...

# codingconventions

[feniix]

fun get_currency_value(currency: String): String {
    val r = khttp.get("<https://api.coinbase.com/v2/exchange-rates?currency=$currency>")
    when (r.statusCode) {
        200 -> return r.jsonObject.getJSONObject("data").getJSONObject("rates").getString("USD")
        else -> return ""
    }
}

[radityagumay]

feniix: should be fun getCurrencyValue

[radityagumay]

just not like pyhton

[radityagumay]

koltin conventions regard to java

[feniix]

thanks

this is how it looks like now

fun getCurrencyValue(currency: String? = "ETH"): String? {
    return try {
        val r = khttp.get("<https://api.coinbase.com/v2/exchange-rates?currency=$currency>")
        logger.debug { r.statusCode }
        when (r.statusCode) {
            200 -> r.jsonObject.getJSONObject("data").getJSONObject("rates").getString("USD")
            else -> null
        }
    } catch (e: Exception) {
        logger.error { e }
        null
    }
}

[radityagumay]

awesome, that much concise

[radityagumay]

for more advance

[radityagumay]

you should use kind of retrofit, and gson

[radityagumay]

use serializable

[radityagumay]

for send object through class or functions

[radityagumay]

👍

[jonlatane]

One more thing! You were right about the duplicate returns being bad. Instead, do

return when(r.statusCode) {
  200 -> r.json....getString("USD")
  else -> ""
}

[radityagumay]

Awesome.

[radityagumay]

👍

[feniix]

thank you

[feniix]

the function looks more like this now

[feniix]

https://github.com/feniix/rate-checker/blob/master/src/main/kotlin/cb/rc/coinbase.kt#L36-L48

[radityagumay]

Awesome. For further, you can use extension function to wrap datetime

[feniix]

what do you mean? @radityagumay ?