https://kotlinlang.org logo
#http4k
Title
# http4k
d

Dmitry Kandalov

06/06/2022, 6:02 PM
I understand that http4k is compiled for java 8 but it brings kotlin-stdlib-jdk8 (and kotlin-stdlib-jdk7) as a dependency to any project even if its JDK is > 8. I was wondering if http4k really needs kotlin-stdlib-jdk8 or could depend only on kotlin-stdlib?
s

s4nchez

06/06/2022, 6:23 PM
In the past you had to choose the kotlin stdlib version. Is kotlin-stdlib meant to provide compatibility to multiple jdk versions?
If so, we can try removing that specific dependency
d

Dmitry Kandalov

06/06/2022, 6:35 PM
AFAIK kotlin-stdlib-jdk8 is literally just a few extension functions for jdk8. And http4k-core seems to compile fine without it.
d

dave

06/06/2022, 6:58 PM
PR it! We did revert to compile against 8 but the new version of the http java client uses the later Java version
👍 1
@Dmitry Kandalov if you can quickly PR changing that kotlin stdlib version then I can release a new version now with the provided dependencies restored as non-bundled
d

Dmitry Kandalov

06/06/2022, 8:13 PM
Yes, I’m syncing my fork etc. Although it’s really just replacing “api(Kotlin.stdlib.jdk8)” with “api(Kotlin.stdlib)” and all tests seem to pass.
d

dave

06/06/2022, 8:13 PM
ok - I'll make that change locally and relase it
👍 1
thanks for discovering these!
d

Dmitry Kandalov

06/06/2022, 8:19 PM
You’re welcome and thank you for fixing them so quickly! 🙂
d

dave

06/06/2022, 8:34 PM
I'm making the same fixed to forkhandles btw
6 Views