https://kotlinlang.org logo
Channels
100daysofcode
100daysofkotlin
100daysofkotlin-2021
advent-of-code
aem
ai
alexa
algeria
algolialibraries
amsterdam
android
android-architecture
android-databinding
android-studio
androidgithubprojects
androidthings
androidx
androidx-xprocessing
anime
anko
announcements
apollo-kotlin
appintro
arabic
argentina
arkenv
arksemdevteam
armenia
arrow
arrow-contributors
arrow-meta
ass
atlanta
atm17
atrium
austin
australia
austria
awesome-kotlin
ballast
bangladesh
barcelona
bayarea
bazel
beepiz-libraries
belgium
benchmarks
berlin
big-data
books
boston
brazil
brikk
budapest
build
build-tools
bulgaria
bydgoszcz
cambodia
canada
carrat
carrat-dev
carrat-feed
chicago
chile
china
chucker
cincinnati-user-group
cli
clikt
cloudfoundry
cn
cobalt
code-coverage
codeforces
codemash-precompiler
codereview
codingame
codingconventions
coimbatore
collaborations
colombia
colorado
communities
competitive-programming
competitivecoding
compiler
compose
compose-android
compose-desktop
compose-hiring
compose-ios
compose-mp
compose-ui-showcase
compose-wear
compose-web
confetti
connect-audit-events
corda
cork
coroutines
couchbase
coursera
croatia
cryptography
cscenter-course-2016
cucumber-bdd
cyprus
czech
dagger
data2viz
databinding
datascience
dckotlin
debugging
decompose
decouple
denmark
deprecated
detekt
detekt-hint
dev-core
dfw
docs-revamped
dokka
domain-driven-design
doodle
dsl
dublin
dutch
eap
eclipse
ecuador
edinburgh
education
effective-kotlin
effectivekotlin
emacs
embedded-kotlin
estatik
event21-community-content
events
exposed
failgood
fb-internal-demo
feed
firebase
flow
fluid-libraries
forkhandles
forum
fosdem
fp-in-kotlin
framework-elide
freenode
french
fritz2
fuchsia
functional
funktionale
gamedev
ge-kotlin
general-advice
georgia
geospatial
german-lang
getting-started
github-workflows-kt
glance
godot-kotlin
google-io
gradle
graphic
graphkool
graphql
graphql-kotlin
graviton-browser
greece
grpc
gsoc
gui
hackathons
hacktoberfest
hamburg
hamkrest
helios
helsinki
hexagon
hibernate
hikari-cp
hire-me
hiring
hongkong
hoplite
http4k
hungary
hyderabad
image-processing
india
indonesia
inkremental
intellij
intellij-plugins
intellij-tricks
internships
introduce-yourself
io
ios
iran
israel
istanbulcoders
italian
jackson-kotlin
jadx
japanese
jasync-sql
java-to-kotlin-refactoring
javadevelopers
javafx
javalin
javascript
jdbi
jhipster-kotlin
jobsworldwide
jpa
jshdq
juul-libraries
jvm-ir-backend-feedback
jxadapter
k2-early-adopters
kaal
kafka
kakao
kalasim
kapt
karachi
karg
karlsruhe
kash_shell
kaskade
kbuild
kdbc
kgen-doc-tools
kgraphql
kinta
klaxon
klock
kloudformation
kmdc
kmm-español
kmongo
knbt
knote
koalaql
koans
kobalt
kobweb
kodein
kodex
kohesive
koin
koin-dev
komapper
kondor-json
kong
kontent
kontributors
korau
korean
korge
korim
korio
korlibs
korte
kotest
kotest-contributors
kotless
kotlick
kotlin-asia
kotlin-beam
kotlin-by-example
kotlin-csv
kotlin-data-storage
kotlin-foundation
kotlin-fuel
kotlin-in-action
kotlin-inject
kotlin-latam
kotlin-logging
kotlin-multiplatform-contest
kotlin-mumbai
kotlin-native
kotlin-pakistan
kotlin-plugin
kotlin-pune
kotlin-roadmap
kotlin-samples
kotlin-sap
kotlin-serbia
kotlin-spark
kotlin-szeged
kotlin-website
kotlinacademy
kotlinbot
kotlinconf
kotlindl
kotlinforbeginners
kotlingforbeginners
kotlinlondon
kotlinmad
kotlinprogrammers
kotlinsu
kotlintest
kotlintest-devs
kotlintlv
kotlinultimatechallenge
kotlinx-datetime
kotlinx-files
kotlinx-html
kotrix
kotson
kovenant
kprompt
kraph
krawler
kroto-plus
ksp
ktcc
ktfmt
ktlint
ktor
ktp
kubed
kug-leads
kug-torino
kvision
kweb
lambdaworld_cadiz
lanark
language-evolution
language-proposals
latvia
leakcanary
leedskotlinusergroup
lets-have-fun
libgdx
libkgd
library-development
lincheck
linkeddata
lithuania
london
losangeles
lottie
love
lychee
macedonia
machinelearningbawas
madrid
malaysia
mathematics
meetkotlin
memes
meta
metro-detroit
mexico
miami
micronaut
minnesota
minutest
mirror
mockk
moko
moldova
monsterpuzzle
montreal
moonbean
morocco
motionlayout
mpapt
mu
multiplatform
mumbai
munich
mvikotlin
mvrx
myndocs-oauth2-server
naming
navigation-architecture-component
nepal
new-mexico
new-zealand
newname
nigeria
nodejs
norway
npm-publish
nyc
oceania
ohio-kotlin-users
oldenburg
oolong
opensource
orbit-mvi
osgi
otpisani
package-search
pakistan
panamá
pattern-matching
pbandk
pdx
peru
philippines
phoenix
pinoy
pocketgitclient
polish
popkorn
portugal
practical-functional-programming
proguard
prozis-android-backup
pyhsikal
python
python-contributors
quasar
random
re
react
reaktive
realm
realworldkotlin
reductor
reduks
redux
redux-kotlin
refactoring-to-kotlin
reflect
refreshversions
reports
result
rethink
revolver
rhein-main
rocksdb
romania
room
rpi-pico
rsocket
russian
russian_feed
russian-kotlinasfirst
rx
rxjava
san-diego
science
scotland
scrcast
scrimage
script
scripting
seattle
serialization
server
sg-user-group
singapore
skia-wasm-interop-temp
skrape-it
slovak
snake
sofl-user-group
southafrica
spacemacs
spain
spanish
speaking
spek
spin
splitties
spotify-mobius
spring
spring-security
squarelibraries
stackoverflow
stacks
stayhungrystayfoolish
stdlib
stlouis
strife-discord-lib
strikt
students
stuttgart
sudan
swagger-gradle-codegen
swarm
sweden
swing
swiss-user-group
switzerland
talking-kotlin
tallinn
tampa
teamcity
tegal
tempe
tensorflow
terminal
test
testing
testtestest
texas
tgbotapi
thailand
tornadofx
touchlab-tools
training
tricity-kotlin-user-group
trójmiasto
truth
tunisia
turkey
turkiye
twitter-feed
uae
udacityindia
uk
ukrainian
uniflow
unkonf
uruguay
utah
uuid
vancouver
vankotlin
vertx
videos
vienna
vietnam
vim
vkug
vuejs
web-mpp
webassembly
webrtc
wimix_sentry
wwdc
zircon
Powered by
Title
d

dave

02/10/2021, 8:02 AM
e

Elizabeth Thomas

02/10/2021, 10:59 PM
I just came across the structured-logging yesterday. Is there a way to test that structured logging is happening when EventFilters are used in-combination with the Http filters?
I have my filter defined like this
data class IncomingHttpRequest(val message: String = "", val status: Int = 0, val duration: Long = 0L) : Event

object ReportHttpTransactionFilter {
  operator fun invoke(
    events: Events = EventFilters.AddTimestamp().then(AutoMarshallingEvents(Jackson)),
    event: Event? = null
  ): Filter = Filter { next ->
    { request ->
      next(request).apply {
        ResponseFilters.ReportHttpTransaction { httpTransaction ->
          events(event ?: IncomingHttpRequest(
            httpTransaction.request.toMessage(),
            httpTransaction.response.status.code,
            httpTransaction.duration.toMillis())
          )
        }
      }
    }
  }
}
And my test class like this: (which fails)
class ReportHttpTransactionFilterSpec : Spek({

  val request = Request(Method.GET, "/bob")
  val response = Response(OK)
  val recording = RecordingEvents()

  test("report http transaction filter emits events with timestamp") {
    val events = EventFilters.AddTimestamp().then(AutoMarshallingEvents(Jackson)).then(recording)
    val event = IncomingHttpRequest("some message", 200, 10)
    val handler = ReportHttpTransactionFilter(events, event).then { response }

    expectThat(handler(request)).isEqualTo(response)
    expectThat(recording.toList()).isEqualTo(listOf<Event>(MetadataEvent(
      event,
      mapOf("timestamp" to Clock.systemUTC().instant())))
    )
  }

})
The recording comes back as emptylist
Am I missing something here?
d

dave

02/11/2021, 8:37 AM
It looks strange - why are you passing in the event which then falls back?
events(event ?: IncomingHttpRequest(
            httpTransaction.request.toMessage(),
            httpTransaction.response.status.code,
            httpTransaction.duration.toMillis())
          )
r

Razvan

02/11/2021, 8:37 AM
I think is yout ReportHttpTransactionFilter that is strange We did it this way:
val events = EventFilters.AddTimestamp().then(AutoMarshallingEvents(AppJackson))
fun LogIncomingRequests() = ResponseFilters.ReportHttpTransaction {
   events(LogHttpTransaction.fromTransaction(it))
}

val app = LogIncomingRequests().then { response }
👍 1
e

Elizabeth Thomas

02/11/2021, 8:55 AM
@Razvan do you mean to say I will have to use LogHttpTransaction in my filter code instead of events(event)?
@dave if an event is passed, it will be events(event) call as in the test code but if event is not passed, it will use the httpTransaction to create IncomingHttpRequest and use it with events.
r

Razvan

02/11/2021, 9:00 AM
LogHttpTransaction is just a custom object like IncomingHttpRequest juste a data class with informations you can replace that with
fun LogIncomingRequests() = ResponseFilters.ReportHttpTransaction {
   events(
      IncomingHttpRequest(
            itrequest.toMessage(),
            it.response.status.code,
            it.duration.toMillis())
          )
   )
}
if it helps to undersand
:thank-you: 1
👍 1
d

dave

02/11/2021, 9:01 AM
@Elizabeth Thomas Yes - and that's exactly what you want to test. 🙃
👍 1
e

Elizabeth Thomas

02/11/2021, 9:08 AM
Okay let me try that!
@Razvan My
events
is configured as
val events = EventFilters.AddTimestamp().then(AutoMarshallingEvents(Jackson)).then(recording)
in my test class. And after running through the filter, when I check the
recording
object, I see it being empty.
@dave ^^
I am missing to see how to validate that events with timestamp were generated.
d

dave

02/11/2021, 6:00 PM
but really you should be testing that your events stack is doing the right thing. assuming that you always want metadata then isolate that part and test it separately to the filter
then you can just test your filter by testing that the correct events (IncomingHttpRequest) were generated, regardless of the metadata
e

Elizabeth Thomas

02/11/2021, 6:48 PM
Thanks @dave will use this approach!
d

dave

02/11/2021, 6:56 PM
👍
e

Elizabeth Thomas

02/11/2021, 8:49 PM
@dave your approach worked. Thanks! But I am failing to understand why my filter defined like this won’t work
object ReportHttpTransactionFilter {
  object Log {
    operator fun invoke(
      rawEvents: Events,
      clock: Clock = Clock.systemUTC()
    ): Filter = Filter { next ->
      { request ->
        val events = AddTimestamp(clock).then(rawEvents)
        next(request).apply {
          ResponseFilters.ReportHttpTransaction(clock = clock) { httpTransaction ->
            events(
              IncomingHttpRequest(
                httpTransaction.request.method,
                httpTransaction.request.uri.path,
                httpTransaction.response.status.code,
                httpTransaction.duration.toMillis()
              )
            )
          }
        }
      }
    }
  }
d

dave

02/11/2021, 8:50 PM
because you're defining a filter within a filter - and that's not how filters work.. 🙂
ResponseFilters.ReportHttpTransaction(clock = clock) { httpTransaction ->
            events(
              IncomingHttpRequest(
                httpTransaction.request.method,
                httpTransaction.request.uri.path,
                httpTransaction.response.status.code,
                httpTransaction.duration.toMillis()
              )
            )
          }
is a filter
you need to do
filter.then(filter).then(handler)
e

Elizabeth Thomas

02/11/2021, 8:52 PM
Ah, okay - I thought filter within a filter is possible.. 🙂
When you get a chance, could you share if there is any documentation that outlines this?
d

dave

02/11/2021, 8:54 PM
e

Elizabeth Thomas

02/11/2021, 8:54 PM
I was following this from ReportHttpTransaction
object ReportHttpTransaction {
        operator fun invoke(
            clock: Clock = Clock.systemUTC(),
            transactionLabeler: HttpTransactionLabeler = { it },
            recordFn: (HttpTransaction) -> Unit
        ): Filter = Filter { next ->
            {
                clock.instant().let { start ->
                    next(it).apply {
                        recordFn(transactionLabeler(HttpTransaction(it, this, between(start, clock.instant()))))
                    }
                }
            }
        }
    }
d

dave

02/11/2021, 8:55 PM
yes - but the
apply()
there is actually doing something and not creting another filter
e

Elizabeth Thomas

02/11/2021, 8:57 PM
Ah, gotcha.. Makes sense. Thanks for explaining it to me!
Also the
LogHttpTransaction.fromTransaction
which @Razvan pointed out, is it in http4k-core? or some other module? I couldnt get the package for it. Again, its probably me doing something wrong.
r

Razvan

02/11/2021, 9:21 PM
No is just a personal data class with fields I want to log, that has a lot of fields and I don’t want to bother pas then in the constructor.
👍 1