Hi, I'm playing with Caching HTTP Traffic example,...

# http4k

[Razvan]

Hi,
I'm playing with Caching HTTP Traffic example, I put breakpoints in DiskTree Sink but never stops.
I changed a bit the response to show the current time to see if the second time it's the same but it does search the cache but the cache is always empty (as it does not enter the Sink function).

fun main() {
    val storage = ReadWriteCache.Disk()

    val withCachedContent = TrafficFilters.ServeCachedFrom(storage).then { Response(OK).body("hello world: ${LocalDateTime.now()}") }
    val aRequest = Request(Method.GET, "<http://localhost:8000/>")
    println("--- FIRST ----")
    println(withCachedContent(aRequest))

    Thread.sleep(1000)
    println("--- SECOND ----")
    println(withCachedContent(aRequest))
}

I expected both output to show the same time and not different ones....

[Razvan]

Same behavior with the Memory cache

[Razvan]

Looking at the Unit Test seems a bit strange as you manually set the response in the cache:

val cache = ReadWriteCache.Memory()
cache[request] = response

does that mean that ServeCachedFrom does not automatically cache requests that does not yet cached ?

[dave]

ah

[dave]

sorry - this is a misunderstanding

[Razvan]

Ok thanks, the Caching Http Traffic example is confusing as it does not show the record part.

[dave]

Maybe switching the order of the examples in that page might work? Feel free to PR it to make it better!

[Razvan]

Guess it just the title as "Replay form cache HTTP Traffic" would make it clearer. And adding at the end the example you gave which does both at the end would make it perfect. Nice system by the way.