https://kotlinlang.org logo
#http4k
Title
# http4k
j

James Shiell

01/16/2020, 1:36 PM
Hmm. Musing for you -
ClientFilters.Gzip
currently compresses the request, and decompresses the response. Which is great, but request compression is pretty esoteric (as you can't guarantee the remote end will support it). Secondly, I don't see us setting an
accept-encoding:gzip
on the request, which means we shouldn't expect to get GZip back. As such, I suggest two changes (i.e. I'm happy to do it, but need a sanity check) a) Change
ClientFilters.Gzip
to set
accept-encoding:gzip
on request, but not to compress the request b) Add a new
ClientFilters.RequestCompressingGzip
to do the above, and additionally compress the request Seem fair? Or am I being daft?
s

s4nchez

01/16/2020, 2:06 PM
It does sound fair. Maybe
ClientFilters.AcceptGzip
for extra clarity?
In any case, I have no objections to splitting this behaviour.
j

James Shiell

01/16/2020, 2:10 PM
Cheers sir, on it 👍
9 Views