https://kotlinlang.org logo
#http4k
Title
# http4k
d

dave

07/26/2019, 12:27 PM
@Ricardo nope. I can just release it if you want. The only thing it hasn't got at the moment is the "include the docs route" PR.
r

Ricardo

07/26/2019, 1:26 PM
I just wanted to double-check the new OpenAPI2 stuff produces valid Swagger before you folks release.
d

dave

07/26/2019, 1:27 PM
well we do have tests.... 🙂
releasing isn't a biggie, but if it's no good to you without the last piece then we should hold off
r

Ricardo

07/26/2019, 1:28 PM
LOL you do, but they don’t test the OpenAPI stuff matches the schema. I think the only thing that does is an command line NPM tool.
Yeah, the last piece means we can get rid of a bunch of hacks in our build scripts.
d

dave

07/26/2019, 1:29 PM
our build generates a client using the OpenApi2 generator
(and OpenApi3)
so if it IS wrong, the OpenApi generator is also wrong 🙂
(there is a validation step)
r

Ricardo

07/26/2019, 1:29 PM
Ah OK, cool, I didn’t know that.
d

dave

07/26/2019, 1:30 PM
not a lot of people do 😉
r

Ricardo

07/26/2019, 1:30 PM
That puts my mind to rest 🙂
d

dave

07/26/2019, 1:30 PM
good -- shall I hold off then or release it?
r

Ricardo

07/26/2019, 1:31 PM
For the description stuff? Yes please. Let me know if the PR needs any changes.
d

dave

07/26/2019, 1:32 PM
sorry - am I holding off until that PR is in, or releasing now? 🙂
r

Ricardo

07/26/2019, 1:37 PM
Sorry, if you could hold off please.
👍 1
d

dave

07/26/2019, 9:29 PM
@Ricardo 3.165.0 is now in bintray and working it's way to maven central. https://github.com/http4k/http4k/blob/master/CHANGELOG.md#changelog
r

Ricardo

07/27/2019, 1:30 PM
Fantastic, thank you. I’ll upgrade on Monday when I’m in the office.
Integrated, tested and deployed. Worked great, thanks David!
👍 1
3 Views