<@UL5UQQ518> nope. I can just release it if you want. The only thing it hasn't got at the moment is ...
d
@Ricardo nope. I can just release it if you want. The only thing it hasn't got at the moment is the "include the docs route" PR.
r
I just wanted to double-check the new OpenAPI2 stuff produces valid Swagger before you folks release.
d
well we do have tests.... ๐Ÿ™‚
releasing isn't a biggie, but if it's no good to you without the last piece then we should hold off
r
LOL you do, but they donโ€™t test the OpenAPI stuff matches the schema. I think the only thing that does is an command line NPM tool.
Yeah, the last piece means we can get rid of a bunch of hacks in our build scripts.
d
our build generates a client using the OpenApi2 generator
(and OpenApi3)
so if it IS wrong, the OpenApi generator is also wrong ๐Ÿ™‚
(there is a validation step)
r
Ah OK, cool, I didnโ€™t know that.
d
not a lot of people do ๐Ÿ˜‰
r
That puts my mind to rest ๐Ÿ™‚
d
good -- shall I hold off then or release it?
r
For the description stuff? Yes please. Let me know if the PR needs any changes.
d
sorry - am I holding off until that PR is in, or releasing now? ๐Ÿ™‚
r
Sorry, if you could hold off please.
๐Ÿ‘ 1
d
@Ricardo 3.165.0 is now in bintray and working it's way to maven central. https://github.com/http4k/http4k/blob/master/CHANGELOG.md#changelog
r
Fantastic, thank you. Iโ€™ll upgrade on Monday when Iโ€™m in the office.
Integrated, tested and deployed. Worked great, thanks David!
๐Ÿ‘ 1