Hey I wonder if anyone is on line to answer a quick question

Question

Hey I wonder if anyone is on line to answer a quick question about the http4k contract library

dave · Answer

Shoot upside down face

Ricardo · Answer

Ha thanks David

Ricardo · Answer

Just looking at the `bindContract` function vs the `bind` function and it appears the former does not create a `HttpHandler`

dave · Answer

for reference Londpn office hours are when were generally about

Ricardo · Answer

Is this deliberate

Ricardo · Answer

Ah OK cheers

dave · Answer

Yes That will create a contract route which sits inside a contract block It s the contract block which creates the handler

Ricardo · Answer

It just would be nice if `ContractRoute` was also an `HttpHandler`

Ricardo · Answer

It means we can test an endpoint without running it through an application or a contract block

Ricardo · Answer

From a design perspective is there a reason why this isn t the case

dave · Answer

You can use a very simple contract block literally just `contract routes+= lt cr gt ` to test it

dave · Answer

But I m not sure that the machinery of the contract routing would allow it to work because it lives outside

dave · Answer

From a design perspective not really TBH Just the way it worked out I haven t got the code in front of me at the mo so I can t check easily upside down face

dave · Answer

But it is a valid question maybe we can look at if it would be possible I am sceptical though

dave · Answer

I m afk but try adding this and see if it would work ```operator fun ContractRoute invoke request Request = toRouter Root match request Response NOT FOUND ```

dave · Answer

< Ricardo> one thing with that though security will not be applied as it s done at the routing layer you do have access in the extension function to get the security filter though so it could also be applied inside the invoke method

dave · Answer

with a tweak

Ricardo · Answer

I have actually modified the `ContractRoute` in a branch Should I send a PR

dave · Answer

Yep thinking about it I think we have all the correct machinery to do it in a more consistent fashion so we might not end up using it exactly as your PR although I will likely merge it but let s see what you ve got already upside down face We ll deffo give you a credit in the changelog anyway Thanks upside down face

Ricardo · Answer

This is what I came up with

Ricardo · Answer

Ricardo · Answer

It s probably a bit duff

dave · Answer

< Ricardo> doesn t matter we can refactor if it needs bashing into shape wink The important thing is that it s a great idea and we should definitely do it if we can upside down face

dave · Answer

although am on hols at the moment so it ll probably be next week before merging it in

Ricardo · Answer

Cool enjoy your hols

Ricardo · Answer

Thanks for the help