< fredrik nordin> looks more like it slightly smiling face i kotlinlang #http4k

Channels

100daysofkotlin

100daysofkotlin-2021

algolialibraries

android-architecture

android-databinding

androidgithubprojects

androidx-xprocessing

arrow-contributors

beepiz-libraries

cincinnati-user-group

codemash-precompiler

codingconventions

competitive-programming

competitivecoding

compose-android

compose-desktop

compose-ui-showcase

connect-audit-events

cscenter-course-2016

domain-driven-design

effective-kotlin

effectivekotlin

embedded-kotlin

event21-community-content

fb-internal-demo

fluid-libraries

framework-elide

getting-started

github-workflows-kt

graviton-browser

image-processing

intellij-plugins

intellij-tricks

introduce-yourself

java-to-kotlin-refactoring

jhipster-kotlin

jvm-ir-backend-feedback

k2-early-adopters

kotest-contributors

kotlin-by-example

kotlin-data-storage

kotlin-foundation

kotlin-in-action

kotlin-multiplatform-contest

kotlin-pakistan

kotlinforbeginners

kotlingforbeginners

kotlinprogrammers

kotlintest-devs

kotlinultimatechallenge

kotlinx-datetime

lambdaworld_cadiz

language-evolution

language-proposals

leedskotlinusergroup

library-development

machinelearningbawas

myndocs-oauth2-server

navigation-architecture-component

ohio-kotlin-users

pattern-matching

pocketgitclient

practical-functional-programming

prozis-android-backup

python-contributors

realworldkotlin

refactoring-to-kotlin

refreshversions

russian-kotlinasfirst

skia-wasm-interop-temp

sofl-user-group

spring-security

squarelibraries

stayhungrystayfoolish

strife-discord-lib

swagger-gradle-codegen

swiss-user-group

tricity-kotlin-user-group

Title

d

dave

01/15/2018, 8:54 PM

@fredrik.nordin looks more like it 🙂 . it's obviously missing the request counter - not sure if you want to put that in as well if you're there? Also, I'm torn as to if to have MetricsFilters object, or to make the Filter creation methods extension methods on ServerFilters and ClientFilters (respectively). Raise the PR and I'll have a mull over that. 🙂

f

fredrik.nordin

01/15/2018, 8:56 PM

Oh interesting idea! I'll have a look at that too and see if I can get an example in there of both. Sounds like extension methods would be good, as that's what people would be most used to, I guess

The resilience filters have their own object though, which is what I used as an example. Not a reason not to do something new in a better way 😄

d

dave

01/15/2018, 9:00 PM

yeah - we're probably inconsistent!

@fredrik.nordin Ideally, yes - however we've found that intellij doesn't always find the extension methods (or at least auto-import them), which makes discovery more difficult.

#http4k Join Slack