Hi guys I know you must be busy and with other priorities at

Question

Hi guys I know you must be busy and with other priorities at hand but do you have any idea when will you have spare time to look into this <https github com orbit mvi orbit mvi pull 127|PR> Thanks slightly smiling face

Mikolaj Leszczynski · Answer

I ll take a look Friday

Guilherme Delgado · Answer

I m available if you need any help +1

appmattus · Answer

Should be around too Ping me when looking < Mikolaj Leszczynski>

Mikolaj Leszczynski · Answer

Probably not the outcome you were looking for < Guilherme Delgado> but we have to make hard choices sometimes

Mikolaj Leszczynski · Answer

We set out to create this project with a certain philosophy in mind and we have to stand by it

Guilherme Delgado · Answer

hey no problem blush it was well explained it s better that you keep your philosophy at least you spend your time on it which i thank you for it

Mikolaj Leszczynski · Answer

Still thank you for the contribution it did push us to review the encapsulation and please do keep it up

Guilherme Delgado · Answer

just one small comment gt it increases the API surface for little reason other than making it easier for a small subset of ppl to hide the container could be a small subset of ppl because they probably don t mind but actually having the container public kind of scratches my OCD sweat smile so yeah I think it s better not to be able to do something like viewmodel container intent in the view

Guilherme Delgado · Answer

but then again gt the functions feel like they are better placed as part of something like androidx compose runtime or a separate library especially given there is no orbit code in the new functions completely agree thumbsup

Guilherme Delgado · Answer

talking about contributions i made another one in the gradle plugin pretty small though i which i had the knowledge to make it work with latest versions of kotlin disappointed grimacing

Mikolaj Leszczynski · Answer

We discussed ways of hiding it and none felt attractive Base class is out of the question because we went for composition for a reason Having a pair of private public fields to hide away container particulars also feels boilerplatey and would require the `ContainerHost` to call ` container intent` instead of simply `intent`

Guilherme Delgado · Answer

yes i don t think the hiding logic is the lib responsibility we can achieve it very well in our end simply by ``` Just to keep it private without public access param initialState The initial state of the container internal fun lt STATE Any SIDE EFFECT Any gt CoroutineScope containerHostVisibilityWrapper initialState STATE = object ContainerHost lt STATE SIDE EFFECT gt override val container = this containerHostVisibilityWrapper container lt STATE SIDE EFFECT gt initialState ```

Guilherme Delgado · Answer

kmm world ^

Guilherme Delgado · Answer

``` Just to keep it private without public access fun lt STATE Parcelable SIDE EFFECT Any gt ViewModel containerHostVisibilityWrapper initialState STATE savedStateHandle SavedStateHandle onCreate state STATE gt Unit = null = object ContainerHost lt STATE SIDE EFFECT gt override val container = this containerHostVisibilityWrapper container lt STATE SIDE EFFECT gt initialState savedStateHandle = savedStateHandle onCreate = onCreate ``` android world ^

Guilherme Delgado · Answer

and that brings us to the point that when androidx gives us that flow extensions this issue it s solved slightly smiling face

Guilherme Delgado · Answer

which btw <https android review googlesource com c platform frameworks support + 2102573 6>

Guilherme Delgado · Answer

will land soon

appmattus · Answer

I thought I d seen them somewhere