Anyone got clue about what parameters allows to fi...

# compose

[Tolriq]

Anyone got clue about what parameters allows to fix text overlapping when using very large fontSize?

[Filip Wiesner]

lineHeight? 🤔

[Tolriq]

Arf of course thanks, don't know why I thought than when modifying the fontsize of the Text it implicitly changed that one too ...

[Halil Ozercan]

I'm curious what have caused the text layout in the image?

[Tolriq]

My fault I have buttons to increase font size on a lyrics view. But only changed the fontSize param of the Text()

[Halil Ozercan]

was lineHeight specified but not changed?

[Tolriq]

Not specified on the Text but it's an M3 theme so it's set there.

[Halil Ozercan]

Ouch! It's not a bug but not a great experience either. I'll redirect this to the team and see what we can do to reduce the friction.

[Tolriq]

In the same vein any reason why we can't add TextUnit ?

[Halil Ozercan]

what do you mean by adding TextUnit?

[Tolriq]

Like 12.sp + 4.sp to add 4 sp to the calculated fontsize

[Sean McQuillan [G]]

This would likely fall into the same issue that compareTo does in TextUnit in that em and sp are dijoint

[Sean McQuillan [G]]

so 1.2.em + 30.sp would have to throw

[Tolriq]

Yep but then what it the proper way to do it ?

[Sean McQuillan [G]]

Do you just want to scale? Multiplication should be well defined

[Sean McQuillan [G]]

taking a step back whats use case

[Tolriq]

Honestly I don't really know the best practice for that case. But since the fontSize is calculated I want to derivate the line height from it to fix the OP

[Tolriq]

So like fontSize+ 4.sp

[Sean McQuillan [G]]

Ah, I think you'll run into "optical sizing" like issues if 4.sp is a constant and fontSize is variable. When fontSize is very large or small 4.sp will look off.

It looks like @Seigo Nonaka already thought about this in 2019 and you can do

val lineHeight = fontSize * 1.1

[Sean McQuillan [G]]

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/[…]/kotlin/androidx/compose/ui/unit/TextUnit.kt;l=140?q=TextUnit

[Tolriq]

Thanks that makes sense. Text is hard for non designers :)

[Colton Idle]

sorta related very recent blog post
https://medium.com/androiddevelopers/fixing-font-padding-in-compose-text-768cd232425b