I'm using compose destinations for navigation in m...

# compose

[zt]

I'm using compose destinations for navigation in my app, and when navigating between screens on my bottom bar, it loses the scroll position in a lazy column I have placed.

My navigation code:

navController.navigate(destination.direction) {
    popUpTo(navController.navGraph.startRoute) {
        saveState = true
    }
    launchSingleTop = true
    restoreState = true
}

[Joseph Hawkes-Cates]

I’m not familiar with destinations, but when you navigate to another view the previous view goes out of composition entirely so the UI state of that lazy column is gone. If you want to retain it, you can store it in the ViewModel for that screen. You can then setup the ViewModel to be restored when you go back to the view and then use the stored position to set the scroll position in your screen.

[zt]

I think it should be saving on its own since internally it uses rememberSaveable though I may be wrong

[Joseph Hawkes-Cates]

IIRC, rememberSaveable just saves across configuration changes, but if your composable goes out of composition altogether I don’t think that will save the value

[Joseph Hawkes-Cates]

I’m not 100% on that, though

[Ian Lake]

rememberSaveable also works across being put on the back stack and coming back

[Ian Lake]

pretty easy to see if that part works by just using a regular navigate() call then going back to that first screen. If that works, then there's something wrong with your bottom nav code

[zt]

Yea I think so too, cause in an earlier build of my app it does save the scroll position

[zt]

So I need to figure out what changed to cause it to behave different

[Ian Lake]

navController.graph.startRoute is not going to work if you have nested graphs - that's specifically why the documentation uses navController.graph.findStartDestination().id to go down as many levels as you have to actually find the first composable destination: https://developer.android.com/jetpack/compose/navigation#bottom-nav

[zt]

I see. I also tried by putting the home destination there instead but same behavior

[Ian Lake]

maybe...try using the code from the docs?

[zt]

I've tried but none of that worked

[zt]

Alright so i managed to narrow it down
for whatever reason having this item at the top of my lazy column is causing it

item {
                LazyRow(
                    modifier = Modifier.fillParentMaxWidth(),
                    verticalAlignment = Alignment.CenterVertically
                ) {
                    item {
                        var selected by remember { mutableStateOf(false) }

                        FilterChip(
                            selected = selected,
                            leadingIcon = {
                                Icon(
                                    imageVector = Icons.Default.Explore,
                                    contentDescription = stringResource(R.string.explore)
                                )
                            },
                            selectedIcon = {
                                Icon(
                                    imageVector = Icons.Default.Explore,
                                    contentDescription = stringResource(R.string.explore)
                                )
                            },
                            label = { Text(stringResource(R.string.explore)) },
                            onClick = { selected = !selected }
                        )
                    }
                }
            }

[Ian Lake]

That sounds like something the test I suggested earlier would have detected: https://kotlinlang.slack.com/archives/CJLTWPH7S/p1656108881731389?thread_ts=1656103626.548659&cid=CJLTWPH7S

[Ian Lake]

But yes, if you aren't actually caching your other source of items (i.e., by using stateIn() in a ViewModel to store the last value so that your data is instantly available when you return to that destination rather than asynchronously loading the items each time you go to that destination) then the first recomposition will only have one element in the list when it tries to restore the scroll position, hence you can't scroll down to the Nth element

[zt]

I see, just tested to find that it also happens with an empty item

item { }

[zt]

class HomeViewModel(
    private val repository: InnerTubeRepository
) : ViewModel() {
    val videos = Pager(PagingConfig(10)) {
        object : PagingSource<String, DomainVideoPartial>() {
            override suspend fun load(params: LoadParams<String>): LoadResult<String, DomainVideoPartial> {
                return try {
                    val trendingVideosResponse = repository.getTrendingVideos(params.key)

                    LoadResult.Page(
                        data = trendingVideosResponse.videos,
                        prevKey = null,
                        nextKey = trendingVideosResponse.continuation
                    )
                } catch (e: Exception) {
                    e.printStackTrace()
                    LoadResult.Error(e)
                }
            }

            override fun getRefreshKey(state: PagingState<String, DomainVideoPartial>): String? = null
        }
    }.flow.cachedIn(viewModelScope)
}

This is what the viewmodel is right now