https://kotlinlang.org logo
Join Slack
Powered by
So, it is a feature or a bug that in `ComposeTest`...
# compose
v
So, it is a feature or a bug that in 
ComposeTest
the lifecycle aware composer is replaced with one controlled by the test? As far as I can tell, this makes it such that things aren't disposed when they would be outside a test environment, and it's causing us memory leaks in the test. More details in the thread.
We have this test rule chain set up. However, there currently isn't a way to introduce the compose test rule without either: 1. Erroring because an activity was launched before the compose test rule started 2. Erroring because we detect leaks before the compose rule disposes things.
Leak trace incoming
Copy code
┬───
│ GC Root: Thread object
│
├─ android.app.Instrumentation$InstrumentationThread instance
│    Leaking: NO (PathClassLoader↓ is not leaking)
│    Thread name: 'Instr: com.company.InstrumentationRunner'
│    ↓ Thread.contextClassLoader
├─ dalvik.system.PathClassLoader instance
│    Leaking: NO (WindowRecomposerPolicy↓ is not leaking and A ClassLoader is never leaking)
│    ↓ ClassLoader.runtimeInternalObjects
├─ java.lang.Object[] array
│    Leaking: NO (WindowRecomposerPolicy↓ is not leaking)
│    ↓ Object[2289]
├─ androidx.compose.ui.platform.WindowRecomposerPolicy class
│    Leaking: NO (a class is never leaking)
│    ↓ static WindowRecomposerPolicy.factory
│                                    ~~~~~~~
├─ java.util.concurrent.atomic.AtomicReference instance
│    Leaking: UNKNOWN
│    Retaining 12 B in 1 objects
│    value = instance of androidx.compose.ui.test.AndroidComposeTest$withWindowRecomposer$1 anonymous class implementing androidx.compose.ui.platform.WindowRecomposerFactory
│    ↓ AtomicReference.value
│                      ~~~~~
├─ androidx.compose.ui.test.AndroidComposeTest$withWindowRecomposer$1 instance
│    Leaking: UNKNOWN
│    Retaining 12 B in 1 objects
│    Anonymous class implementing androidx.compose.ui.platform.WindowRecomposerFactory
│    ↓ AndroidComposeTest$withWindowRecomposer$1.this$0
│                                                ~~~~~~
├─ androidx.compose.ui.test.AndroidComposeTest instance
│    Leaking: UNKNOWN
│    Retaining 434 B in 15 objects
│    ↓ AndroidComposeTest.testCoroutineDispatcher
│                         ~~~~~~~~~~~~~~~~~~~~~~~
├─ kotlinx.coroutines.test.UnconfinedTestDispatcherImpl instance
│    Leaking: UNKNOWN
│    Retaining 20 B in 1 objects
│    ↓ UnconfinedTestDispatcherImpl.scheduler
│                                   ~~~~~~~~~
├─ kotlinx.coroutines.test.TestCoroutineScheduler instance
│    Leaking: UNKNOWN
│    Retaining 3.2 MB in 79814 objects
│    ↓ TestCoroutineScheduler.events
│                             ~~~~~~
├─ kotlinx.coroutines.internal.ThreadSafeHeap instance
│    Leaking: UNKNOWN
│    Retaining 3.2 MB in 79807 objects
│    ↓ ThreadSafeHeap.a
│                     ~
├─ kotlinx.coroutines.internal.ThreadSafeHeapNode[] array
│    Leaking: UNKNOWN
│    Retaining 3.2 MB in 79806 objects
│    ↓ ThreadSafeHeapNode[0]
│                        ~~~
├─ kotlinx.coroutines.test.TestDispatchEvent instance
│    Leaking: UNKNOWN
│    Retaining 3.2 MB in 79805 objects
│    ↓ TestDispatchEvent.marker
│                        ~~~~~~
├─ kotlinx.coroutines.test.CancellableContinuationRunnable instance
│    Leaking: UNKNOWN
│    Retaining 3.2 MB in 79803 objects
│    ↓ CancellableContinuationRunnable.continuation
│                                      ~~~~~~~~~~~~
├─ kotlinx.coroutines.CancellableContinuationImpl instance
│    Leaking: UNKNOWN
│    Retaining 3.2 MB in 79802 objects
│    ↓ CancellableContinuationImpl.delegate
│                                  ~~~~~~~~
├─ kotlinx.coroutines.internal.DispatchedContinuation instance
│    Leaking: UNKNOWN
│    Retaining 3.2 MB in 79793 objects
│    ↓ DispatchedContinuation.continuation
│                             ~~~~~~~~~~~~
├─ androidx.compose.foundation.ClickableKt$handlePressInteraction$2$delayJob$1 instance
│    Leaking: UNKNOWN
│    Retaining 3.2 MB in 79792 objects
│    Anonymous subclass of kotlin.coroutines.jvm.internal.SuspendLambda
│    ↓ ClickableKt$handlePressInteraction$2$delayJob$1.$delayPressInteraction
│                                                      ~~~~~~~~~~~~~~~~~~~~~~
├─ androidx.compose.runtime.ParcelableSnapshotMutableState instance
│    Leaking: UNKNOWN
│    Retaining 3.1 MB in 79782 objects
│    ↓ SnapshotMutableStateImpl.next
│                               ~~~~
├─ androidx.compose.runtime.SnapshotMutableStateImpl$StateStateRecord instance
│    Leaking: UNKNOWN
│    Retaining 3.1 MB in 79781 objects
│    ↓ SnapshotMutableStateImpl$StateStateRecord.value
│                                                ~~~~~
├─ androidx.compose.foundation.ClickableKt$clickable$4$delayPressInteraction$1 instance
│    Leaking: UNKNOWN
│    Retaining 36 B in 2 objects
│    Anonymous subclass of kotlin.jvm.internal.Lambda
│    ↓ ClickableKt$clickable$4$delayPressInteraction$1.$isRootInScrollableContainer
│                                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
├─ androidx.compose.foundation.Clickable_androidKt$isComposeRootInScrollableContainer$1 instance
│    Leaking: UNKNOWN
│    Retaining 16 B in 1 objects
│    Anonymous subclass of kotlin.jvm.internal.Lambda
│    ↓ Clickable_androidKt$isComposeRootInScrollableContainer$1.$view
│                                                               ~~~~~
├─ androidx.compose.ui.platform.AndroidComposeView instance
│    Leaking: YES (View.mContext references a destroyed activity)
│    Retaining 3.1 MB in 79772 objects
│    View not part of a window view hierarchy
│    View.mAttachInfo is null (view detached)
│    View.mWindowAttachCount = 1
│    mContext instance of flow.path.FlowPathContextWrapper, wrapping activity com.company.MainActivity with mDestroyed = true
│    ↓ AndroidComposeView._autofill
├─ androidx.compose.ui.autofill.AndroidAutofill instance
│    Leaking: YES (AndroidComposeView↑ is leaking)
│    Retaining 20 B in 1 objects
│    ↓ AndroidAutofill.autofillManager
├─ android.view.autofill.AutofillManager instance
│    Leaking: YES (AndroidComposeView↑ is leaking)
│    Retaining 103 B in 4 objects
│    mContext instance of com.company.MainActivity with mDestroyed = true
│    ↓ AutofillManager.mContext
╰→ com.company.MainActivity instance
     Leaking: YES (ObjectWatcher was watching this because com.company.MainActivity received Activity#onDestroy() callback and Activity#mDestroyed is true)
     Retaining 27.2 kB in 1079 objects
     key = c4271098-7bee-44b7-8c39-72e70a1dceec
     watchDurationMillis = 6358
     retainedDurationMillis = 1358
     mApplication instance of com.company.MyTestApp
     mBase instance of androidx.appcompat.view.ContextThemeWrapper
cc/ @Zach Klippenstein (he/him) [MOD] @py
z
@Jelle Fresen [G]
p
Btw these leaks manifest because an AndroidComposeView is removed from the view hierarchy (as part of normal navigation in the test) before end of test & activity destroy.
The compose test rule cleans up its bad references at the end of the test.. better than no cleaning up, but still not good. All refs to a view should be let go as soon as its detached.
Mmm re reading the trace maybe I got that one wrong as it seems the activity is destroyed here. Same principle though, activities come and go during a test, cleanup should happen as soon as activities are gone and not just at the end of a test rule
z
Please file a bug - or did you file one for the symptom? I can update it with these details if you don’t have permission
v
I have not filed a bug yet. I can file one!
@Ian G. Clifton
8 Views
Open in Slack
PreviousNext
Powered by