https://kotlinlang.org logo
Title
e

elihart

07/07/2022, 11:09 PM
Is anyone else affected by https://github.com/google/ksp/issues/1034 or looking into it? It seems to be blocking our update to Kotlin 1.7
j

Jiaxiang

07/07/2022, 11:35 PM
I am planning to take a look.
e

elihart

07/08/2022, 1:22 AM
thank you 🙂
j

Jiaxiang

07/19/2022, 12:29 AM
I tried to reproduce this case in our test, but failed to do so. It might be related to android plugin, is your project also built with android plugin? @elihart
e

elihart

07/19/2022, 1:11 AM
yes, we also have the android plugin
j

Jiaxiang

08/19/2022, 8:53 PM
While the fix is already merged in main branch, before our next release, we decided to release a snapshot that contains the fix for you to verify if our fix is working for your project. you can add
maven("<https://oss.sonatype.org/content/repositories/snapshots/>")
to your build script and use
1.7.20-Beta-1.0.7-SNAPSHOT
version of KSP and 1.7.20-Beta compiler to verify.
e

elihart

08/20/2022, 5:27 PM
thank you, we can try it early next week
we tried the new version, but there seems to be a change that is incompatible with sqldelight (version 1.5.3) so gradle configuration fails and we can’t even get to the build steps to verify your fix 😕
Caused by: java.lang.IllegalStateException: Couldn't find debug in {androidTest=null, androidTestDebug=null, androidTestRelease=null, debug=null, main=null, release=null, test=null, testDebug=null, testFixtures=null, testFixturesDebug=null, testFixturesRelease=null, testRelease=null}	
at com.squareup.sqldelight.gradle.kotlin.SourceRootsKt.sources(SourceRoots.kt:105)	
at com.squareup.sqldelight.gradle.kotlin.SourceRootsKt.sources(SourceRoots.kt:46)	
at com.squareup.sqldelight.gradle.SqlDelightDatabase$sources$2.invoke(SqlDelightDatabase.kt:30)	
at com.squareup.sqldelight.gradle.SqlDelightDatabase$sources$2.invoke(SqlDelightDatabase.kt:30)	
at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)	
at com.squareup.sqldelight.gradle.SqlDelightDatabase.getSources(SqlDelightDatabase.kt:30)	
at com.squareup.sqldelight.gradle.SqlDelightDatabase.registerTasks$sqldelight_gradle_plugin(SqlDelightDatabase.kt:130)	
at com.squareup.sqldelight.gradle.SqlDelightPlugin.setupSqlDelightTasks(SqlDelightPlugin.kt:137)	
at com.squareup.sqldelight.gradle.SqlDelightPlugin.access$setupSqlDelightTasks(SqlDelightPlugin.kt:34)	
at com.squareup.sqldelight.gradle.SqlDelightPlugin$apply$androidPluginHandler$1.invoke$lambda-0(SqlDelightPlugin.kt:54)	
at org.gradle.configuration.internal.DefaultUserCodeApplicationContext$CurrentApplication$1.execute(DefaultUserCodeApplicationContext.java:123)	
at org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator$BuildOperationEmittingAction$1.run(DefaultListenerBuildOperationDecorator.java:171)
we haven’t had time to dive into this error yet, so unfortunately it seems like we won’t be able to verify your fix for now
j

Jiaxiang

08/24/2022, 8:20 PM
Thanks for trying it out 🙂 it is unfortunate that we had to ship this snapshot with a beta version of compiler, which could cause issues like this.
e

elihart

08/29/2022, 5:58 PM
do you know if you’ll be making a kotlin 1.7.10 based release with this fix?
j

Jiaxiang

08/29/2022, 6:01 PM
not sure at this point, I will discuss this internally and come back to you tomorrow.
another thing is that if we are to make a 1.7.10 release, it will still happen around the same time 1,7.20 is released, so not sure if that fits your timeline.
e

elihart

08/29/2022, 9:14 PM
ok, thank you for the information