Hello friends, I have a draft of an article about ...
# github-workflows-kt
j
Hello friends, I have a draft of an article about github-actions.kts Any feedback? If you find typo or little things like that, you should be able to edit the page. If you can’t edit the page let me know. cc @Piotr Krzemiński https://github.com/jmfayard/jmfayard/wiki/GitHub-Actions:-a-New-Hope-in-YAML-Wasteland
👍 3
👍🏾 1
🎉 1
l
I personally call it
github-actions.kts
I liked this line a lot
I'd even call for a project rename, it's very catchy
😄 1
p
Thanks, I'm in vacation 🌴 and coming back around the end of next week, then I'll be able to share meaningful feedback. For now I'm just excited about this article 😄
I mostly see just typos + wondering if it would be a good opportunity to mention https://github.com/krzema12/github-actions-typing as the ultimate way to scale up regarding support for actions. 4 actions/2 owners have already onboarded it
K 1
j
@Piotr Krzemiński yes, I will add a paragraph in the FAQ about that
🆒 1
p
Consider mentioning it already when you write "We introduced a new file action-types.yml that contains it". Technically we still mostly use our local DSL in WrappersToGenerate.kt, maybe it's also worth mentioning in case someone wants to contribute a new wrapper. BTW, I'm thinking about getting rid of WrappersToGenerate.kt in favor of local action-types.yml
TODO: check if GitHub's YAML editor would catch some of the 7 errors mentioned in the example
j
I’ve found a bug in the script-generator. A breaking change we didn’t notice https://github.com/krzema12/github-actions-kotlin-dsl/pull/339
👍 1
p
@jmfayard cool, thanks for noticing it! I didn't catch it when introducing the breaking change because no tests caught it
j
that’s why I added a test 🙂
🆒 1